Unify ci error entry#38
Open
david30907d wants to merge 4 commits into
Open
Conversation
…ants Make "read .ai-verify/result.json -> logs/<job>.log" the single error entry for the local opencode /goal fix loop, regardless of which verify variant or skill is used. - Add scripts/ci-run-lib.sh; route all six verify-*.sh through it so ci, parallel, changed, staged, branch and package all emit the same .ai-verify/result.json + per-job logs. - Fix set -e dead code in verify-changed/staged (FAILED + log pointer now print); drop dead RESULT_FILE in verify-branch; add turbo --summarize to affected gates. - Give each .agents/skills sub-skill a "Where the error already is" entry block (5 point into .ai-verify; coverage/security flagged as exceptions); fix the CLAUDE.md AI-fix-loop step that referenced a nonexistent per-step log. - lint-staged: run ruff format on .py to match CI's ruff format --check. - Delete orphan .husky/test-surface-expander.md. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…un_logged helper
Remove the test-hygiene scanner subsystem — never wired into CI, package.json,
turbo, or husky: scripts/test-hygiene.ts, root test-scanner.js, .ai/test-hygiene.md,
and 8 source-manifest.{test,spec}.ts scaffolds (comment-only imports, zero real
coverage). Zero residual references remain.
design-tokens' only test was its manifest; add a minimal vitest.config.ts with
passWithNoTests so test:ci stays green with an empty suite. Reword two comments
that referenced the deleted manifest (landing-page/knip.ts, types/vitest.config.ts).
Extract the duplicated set +e -> turbo -> record block from verify-changed/staged/
branch into cirun_run_logged() in ci-run-lib.sh (the source of the prior dead-code
bug). TURBO_SCM_* passed via env prefix.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This root-level stylesheet was never imported anywhere — not by any
src/ entry, public/ HTML, next.config.ts, or vercel.json, and it is not
copied into the static export (out/). It also carried ~100 hardcoded
swatches built around an off-brand purple gradient (#667eea / #764ba2),
neither of which exists in packages/design-tokens. The live styles are
src/app/{globals,landing}.css + pitch/pitch.css, which consume the
design-tokens CSS variables (brand accent tan #d4c5a3).
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Remove verify subcommands with no real consumer, leaving ci/changed/branch/ parallel/deploy. Drop verify-local.sh, verify-staged.sh, verify-package.sh: - staged is a strict subset of changed, zero machine consumers, not in the docs - local (bare default) and package are superseded by changed/parallel Bare `pnpm verify` now defaults to `parallel` (the documented full local gate before opening a PR) instead of the removed `local`. Scrub the now-stale references in CLAUDE.md, the monorepo-ci-debugging skill, and ci-run-lib.sh. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<1-2 sentences: what changed and why>
Changes
Test Plan
pnpm verifypasses locallypnpm --filter @zapengine/frontend test:unit>Risk
<What could break? Include affected services and blast radius.>
Rollback
Checklist
CLAUDE.mdfiles.env.exampleif added env-var referencespnpm --filter @zapengine/analytics-engine test:strategy-snapshot:fastpnpm contracts checkcovers the change