Skip to content

fix: the code blocks sensitive credential options fr... in... - #26

Merged
yunze7373 merged 1 commit into
yonro:mainfrom
anupamme:fix-repo-memory-os-cli-xmemo-sensitive-cli-flags
Sep 1, 2026
Merged

fix: the code blocks sensitive credential options fr... in...#26
yunze7373 merged 1 commit into
yonro:mainfrom
anupamme:fix-repo-memory-os-cli-xmemo-sensitive-cli-flags

Conversation

@anupamme

Copy link
Copy Markdown
Contributor

Summary

Fix high severity security issue in skills/xmemo/scripts/xmemo-skill.mjs.

Vulnerability

Field Value
ID V-001
Severity HIGH
Scanner multi_agent_ai
Rule V-001
File skills/xmemo/scripts/xmemo-skill.mjs:386
Assessment Likely exploitable

Description: The code blocks sensitive credential options from CLI flags, but the XMEMO_KEY environment variable can still be exposed through process listings, shell history files, or inline environment variable assignment. Additionally, the --allow-plaintext flag permits storing credentials in plaintext files at ~/.xmemo/skill-credentials.json.

Evidence

Exploitation scenario: An attacker with local system access can view process listings (ps aux) or shell history files to capture the XMEMO_KEY environment variable value if it's set in shell startup scripts or passed.

Scanner confirmation: multi_agent_ai rule V-001 flagged this pattern.

Threat Model Context

This is a Node.js library - vulnerabilities affect downstream consumers who use this package.

Changes

  • skills/xmemo/scripts/xmemo-skill.mjs

Behavior Preservation

The change is scoped to 1 file on the vulnerable path; it only tightens handling of untrusted input and leaves valid inputs unaffected.


Automated security fix by OrbisAI Security

Automated security fix generated by OrbisAI Security
@yunze7373
yunze7373 merged commit bc28565 into yonro:main Sep 1, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants