Fix test compilation on main: remove duplicate testAvailableAfterEmptyBlock - #149
Merged
Merged
Conversation
yawkat
enabled auto-merge (squash)
September 25, 2026 18:05
yawkat
disabled auto-merge
September 25, 2026 18:07
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #149 +/- ##
============================================
+ Coverage 79.14% 79.76% +0.61%
- Complexity 555 562 +7
============================================
Files 42 42
Lines 1841 1838 -3
Branches 251 247 -4
============================================
+ Hits 1457 1466 +9
+ Misses 247 239 -8
+ Partials 137 133 -4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
maincurrently fails to compile its tests, and the "Run tests" workflow has been failing since c8ebf97:#129 and c8ebf97 each added a
testAvailableAfterEmptyBlocktest, and both check thatavailable()is 0 after the terminating empty block. This PR keeps the copy from #129, which covers bothstopOnEmptyBlocksettings, and removes the later one.There are no other conflicts between these merges.
LZ4BlockInputStreamresetso = 0only once in the empty-block branch, and the full suite passes:🤖 Generated with Claude Code