Make stream failures sticky in LZ4FrameInputStream and LZ4BlockInputStream - #145
Merged
Merged
Conversation
…tream After an IOException from reading a block or frame header, both streams could keep returning data they had already rejected, or throw unchecked exceptions (NullPointerException, IndexOutOfBoundsException). Record the first failure, wrapping RuntimeExceptions in an IOException, and make later read(), skip() and the frame stream's expected content size methods throw an IOException caused by it. available() returns 0 once the stream has failed. Fixes #101 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
yawkat
enabled auto-merge (squash)
September 25, 2026 19:03
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #145 +/- ##
============================================
+ Coverage 79.76% 80.43% +0.67%
- Complexity 562 576 +14
============================================
Files 42 42
Lines 1838 1876 +38
Branches 247 253 +6
============================================
+ Hits 1466 1509 +43
Misses 239 239
+ Partials 133 128 -5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dongjoon-hyun
added a commit
to apache/spark
that referenced
this pull request
Sep 28, 2026
### What changes were proposed in this pull request? This PR aims to upgrade `at.yawk.lz4:lz4-java` to 1.12.0. ### Why are the changes needed? To bring the latest security fixes of `v1.11.4` and the stricter input validation of `v1.12.0`. The upstream recommends `1.12.0` over `1.11.4`. - https://github.com/yawkat/lz4-java/releases/tag/v1.12.0 (2026-09-25) - [Throw IOException for invalid or unsupported frame descriptors](yawkat/lz4-java#133) - [Reject short output in LZ4DecompressorWithLength safe paths](yawkat/lz4-java#126) - [Make stream failures sticky in LZ4FrameInputStream and LZ4BlockInputStream](yawkat/lz4-java#145) - https://github.com/yawkat/lz4-java/releases/tag/v1.11.4 (2026-09-25) - [LZ4FrameInputStream reallocates block buffers for every frame, allowing CPU and GC amplification from small inputs](GHSA-gm45-99xc-r7wv) - [LZ4BlockInputStream with stopOnEmptyBlock=false recurses once per empty block, causing StackOverflowError](GHSA-343h-94h5-c4wr) - [Native library extraction to a shared temporary directory is vulnerable to file replacement by another local user](GHSA-mcr4-qmvw-px4g) Note that Apache Spark's `LZ4CompressionCodec` reads streams via `LZ4BlockInputStream` with `withStopOnEmptyBlock(false)`, which is the code path fixed by `GHSA-343h-94h5-c4wr`. **Full Changelog**: yawkat/lz4-java@v1.11.3...v1.12.0 ### Does this PR introduce _any_ user-facing change? No. There is no behavior change for valid LZ4 streams. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Claude Opus 5.5 Closes #59093 from dongjoon-hyun/SPARK-59820. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #101.
If a caller caught an
IOExceptionfrom either stream and kept reading, the stream could return data it had already rejected, or throw unchecked exceptions:available()could go negative, andread(byte[])could throwIndexOutOfBoundsException.Both classes now record the first failure. Any
IOExceptionorRuntimeExceptionthat escapesrefill,nextFrameInfoorreadBlockis stored, withRuntimeExceptionwrapped inIOException. After that:read(),read(byte[],int,int),skip()and the frame stream'sgetExpectedContentSize()/isExpectedContentSizeDefined()throwIOException("Stream previously failed", cause). This check runs before any EOF early return.available()returns 0, andclose()still works.Behaviour change (release note): once any read, skip or header parse fails, the stream stays failed. That includes retrying after a transient error from the underlying stream, such as
SocketTimeoutException. Such retries were already unsafe, because partially read input had been consumed.Tests (they fail without the fix):
originalLen(-1 andMAX_VALUE).IOException.Merge note: this may conflict with #128 (
refill()header handling) and #133 (tests appended at the same place). The resolution is to keep both: #128's header logic goes at the start ofrefill0().🤖 Generated with Claude Code