Reject short output in LZ4DecompressorWithLength safe paths - #126
Merged
Merged
Conversation
The safe-decompressor overloads passed the declared length as the maximum destination length but accepted any shorter output, returning a truncated array or a short written count. Throw LZ4Exception when the decompressed size differs from the length prefix, matching the fast paths. decompress(ByteBuffer, ByteBuffer) checks before moving the buffer positions. Fixes #105 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
yawkat
force-pushed
the
fix/issue-105
branch
from
September 25, 2026 15:29
758fbfa to
02e70af
Compare
Owner
Author
|
potentially breaking? |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
yawkat
enabled auto-merge (squash)
September 25, 2026 19:03
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #126 +/- ##
============================================
+ Coverage 79.76% 79.81% +0.05%
- Complexity 562 564 +2
============================================
Files 42 42
Lines 1838 1843 +5
Branches 247 247
============================================
+ Hits 1466 1471 +5
+ Misses 239 238 -1
- Partials 133 134 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
dongjoon-hyun
added a commit
to apache/spark
that referenced
this pull request
Sep 28, 2026
### What changes were proposed in this pull request? This PR aims to upgrade `at.yawk.lz4:lz4-java` to 1.12.0. ### Why are the changes needed? To bring the latest security fixes of `v1.11.4` and the stricter input validation of `v1.12.0`. The upstream recommends `1.12.0` over `1.11.4`. - https://github.com/yawkat/lz4-java/releases/tag/v1.12.0 (2026-09-25) - [Throw IOException for invalid or unsupported frame descriptors](yawkat/lz4-java#133) - [Reject short output in LZ4DecompressorWithLength safe paths](yawkat/lz4-java#126) - [Make stream failures sticky in LZ4FrameInputStream and LZ4BlockInputStream](yawkat/lz4-java#145) - https://github.com/yawkat/lz4-java/releases/tag/v1.11.4 (2026-09-25) - [LZ4FrameInputStream reallocates block buffers for every frame, allowing CPU and GC amplification from small inputs](GHSA-gm45-99xc-r7wv) - [LZ4BlockInputStream with stopOnEmptyBlock=false recurses once per empty block, causing StackOverflowError](GHSA-343h-94h5-c4wr) - [Native library extraction to a shared temporary directory is vulnerable to file replacement by another local user](GHSA-mcr4-qmvw-px4g) Note that Apache Spark's `LZ4CompressionCodec` reads streams via `LZ4BlockInputStream` with `withStopOnEmptyBlock(false)`, which is the code path fixed by `GHSA-343h-94h5-c4wr`. **Full Changelog**: yawkat/lz4-java@v1.11.3...v1.12.0 ### Does this PR introduce _any_ user-facing change? No. There is no behavior change for valid LZ4 streams. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Claude Opus 5.5 Closes #59093 from dongjoon-hyun/SPARK-59820. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #105.
The safe-decompressor overloads of
LZ4DecompressorWithLengthpassed the declared length asmaxDestLenbut never checked that that many bytes were produced. As a result, a length prefix larger than the actual data had two effects:getDecompressedLength()could miss.All safe paths now throw
LZ4Exceptionwhen the decompressed size doesn't match the prefix. The fast paths already required an exact length.destLenitself and checks the count.decompress(ByteBuffer, ByteBuffer)checks before it updates any positions.Javadoc is updated to match.
Behaviour change: only malformed input, where the prefix doesn't match the data, is affected.
LZ4CompressorWithLengthnever produces such input.Test:
testDecompressorWithLengthRejectsShortOutputcovers all seven safe overloads with heap and direct buffers. It also checks that buffer positions are unchanged after a failure. It fails without the fix.LZ4TestandOutOfBoundsTestpass.🤖 Generated with Claude Code