Type the Connector family with all 22 children. - #1983
Open
shadyvb wants to merge 1 commit into
Open
Conversation
shadyvb
marked this pull request as ready for review
September 2, 2026 10:10
shadyvb
force-pushed
the
ticket/XWPENG-47-typed-props-connectors
branch
from
September 2, 2026 10:12
bbf96d2 to
e067c30
Compare
Rector plus hand invariance alignment so parent and child property types match. Connector::$name is string (non-nullable) on the base and every child.
shadyvb
force-pushed
the
ticket/XWPENG-47-typed-props-connectors
branch
from
September 2, 2026 14:30
e067c30 to
49cde6b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #000.
Describe your approach and how it fixes the issue.
Checklist
contributing.md).Release Changelog
Release Checklist
masterbranch.readme.txt.stream.php.Stable taginreadme.txt.classes/class-plugin.php.Change
[ ]to[x]to mark the items as done.