Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3707.
The CuPy benchmark helper tested the
has_cuda_and_cupyfunction object instead of calling it. On a host without usable CUDA/CuPy, this bypassed the intendedNotImplementedErrorskip and attempted to import or use CuPy. Call the existing predicate, matching the neighboring dask+cupy branch.Five regression cases cover CuPy absent or present with CUDA unavailable for both GPU backend choices, and confirm that the CuPy conversion path is still reached when the predicate returns true. The tests use real project imports and mock only the capability result and CuPy calls; they require no GPU.
Validation
python -m pytest benchmarks/tests/test_common.py -q: 5 passed; reverting the one-line fix gives 3 failed, 2 passed.git diff --checkandpip checkpassed.AI-assisted review
Reviewed using an adapted local checklist from the project's command suite, as permitted by CONTRIBUTING.md. The review checked the full changed files, capability dispatch, test failure modes, API compatibility and performance implications. No further source changes were needed.
The complete
/review-prcommand was not run: this review preceded PR creation, and its referenced/humanizerskill was not available locally. Numerical validation sweeps do not apply to this capability-guard-only fix. GPU execution and full-suite coverage remain unverified as noted above.