Repository navigation
Allow protobuf 7 - #223
Merged
Merged
Allow protobuf 7#223
Conversation
The protobuf 7 runtime only rejects gencode newer than itself, so it loads the v6 gencode. Route protobuf 7 to the v6 modules and raise the upper bound to <8, so the SDK installs next to packages that pin protobuf 7, such as Home Assistant 2026.10. Fixes xai-org#222
Omar-V2
approved these changes
Oct 23, 2026
gyang-xai
approved these changes
Oct 23, 2026
mark-xai
approved these changes
Oct 23, 2026
This was referenced Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #222
The SDK can't be installed next to packages that pin protobuf 7 (Home Assistant 2026.10 pins
protobuf==7.36.0). Even with the pin relaxed,proto/__init__.pyraisesUnsupported protobuf versionon 7.x.protobuf>=5.29.4,<8, with the matchinguv.lockspecifier souv sync --lockedstill passes. The locked version is unchanged.runtime_version.ValidateProtobufRuntimeVersiononly rejects gencode newer than the runtime, and the builder, descriptor and well-known-type APIs used by the v6 gencode and the SDK are all still there.