Skip to content

[MARIO-570] Adding dependabot autoappoval/merge#61

Open
IndianAg0711 wants to merge 4 commits intomainfrom
mario-570
Open

[MARIO-570] Adding dependabot autoappoval/merge#61
IndianAg0711 wants to merge 4 commits intomainfrom
mario-570

Conversation

@IndianAg0711
Copy link
Copy Markdown

@IndianAg0711 IndianAg0711 commented Apr 23, 2026

JIRA Ticket

MARIO-570

What Are We Doing Here

Adding config for dependabot to auto approve and merge minor and patch dep updates that pass ci

@IndianAg0711 IndianAg0711 requested a review from a team as a code owner April 23, 2026 15:34
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 23, 2026

⚠️ No Changeset found

Latest commit: 7e91efb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Comment thread .github/dependabot.yml Outdated
- "wpengine/mario"
- package-ecosystem: "npm"
directory: "/"
directory: "/assets"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure that /assets is a valid directory in this repo. Should the directory just be /?

Comment thread .github/CODEOWNERS Outdated
package.json @pe-domino-bot @wpengine/mario
package-lock.json @pe-domino-bot @wpengine/mario
Dockerfile @pe-domino-bot @wpengine/mario
docker-compose.yml @pe-domino-bot @wpengine/mario No newline at end of file
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
docker-compose.yml @pe-domino-bot @wpengine/mario

steps:
- name: Dependabot metadata
id: metadata
uses: dependabot/fetch-metadata@25dd0e34f4fe68f24cc83900b1fe3fe149efef98 # v3.1.0
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes for the other repo used dependabot/fetch-metadata@v3.1.0. Using the SHA like you have here is probably the safer choice between the two, but I wanted to note the difference.

Comment thread .github/dependabot.yml Outdated
ignore:
- dependency-name: "*"
update-types: ["version-update:semver-major"]
open-pull-requests-limit: 10 No newline at end of file
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit, but I noticed there is no newline at the end of the file.

Suggested change
open-pull-requests-limit: 10
open-pull-requests-limit: 10

Comment thread .github/dependabot.yml
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we include the github-actions package ecosystem for updates as well? Since dependabot/fetch-metadata is pinned by SHA, it won't receive updates unless something bumps it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants