Skip to content

Add a step for scenarios that need a specific set of themes - #406

Merged
schlessera merged 2 commits into
mainfrom
only-these-themes
Oct 31, 2026
Merged

schlessera merged 2 commits into
mainfrom
only-these-themes

Conversation

@schlessera

@schlessera schlessera commented Oct 30, 2026 •

Copy link
Copy Markdown
Member

Several feature files start every scenario with wp theme delete --all --force followed by one or more wp theme install calls, to get a known set of themes. Given only these installed themes: and Given only these installed and active themes: replace those Backgrounds with a single step, using the cached installs from #404.

Builds on #404. Fixes #376.

Measurements

Each draft pull request below points wp-cli/wp-cli-tests at this branch. Its Testing workflow ran through workflow_dispatch, together with the same workflow on an unchanged copy of the default branch, three times each where possible. Times are the Run Behat step summed over the matrix jobs that ran in every measured run (median over runs, in job minutes). Retried jobs passed only because behat-rerun repeated their failed scenarios.

Repository Jobs Runs Before (min) After (min) Change Median per job Failed jobs Retried jobs
wp-cli/extension-command#565 51 3/3 856.1 802.3 -6.3% -2.8% 0 → 0 7 → 1
wp-cli/entity-command#681 51 3/3 979.2 946.7 -3.3% -0.9% 3 → 3 4 → 3
Total 1835.3 1748.9 -4.7%

Failing scenarios

Scenarios that failed at least once in a measured run, including runs where behat-rerun then passed them.

  • wp-cli/extension-command: failing with and without the change: features/plugin.feature (List plugins) (1/3 runs)
  • wp-cli/extension-command: failing only without the change: features/theme.feature (Doing wp theme list does a force check by default, deleting any existing transient values) (2/3 runs)
  • wp-cli/entity-command: failing only without the change: features/post.feature (Filtering by meta, time of day and order) (1/3 runs)

@schlessera schlessera added the scope:testing Related to testing label Oct 30, 2026
@schlessera
schlessera requested a review from a team as a code owner October 30, 2026 19:40
@coderabbitai

coderabbitai Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Caution

Review failed

The pull request is closed.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@codecov

codecov Bot commented Oct 30, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/Context/FeatureContext.php 0.00% 8 Missing ⚠️
src/Context/GivenStepDefinitions.php 0.00% 5 Missing ⚠️

📢 Thoughts on this report? Let us know!

schlessera and others added 2 commits October 31, 2026 04:11
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@schlessera
schlessera force-pushed the cached-extension-installs branch from 9f0ac46 to e013cfa Compare October 31, 2026 03:11
Base automatically changed from cached-extension-installs to main October 31, 2026 18:39
@schlessera
schlessera merged commit 23c6dc4 into main Oct 31, 2026
64 of 66 checks passed
@schlessera
schlessera deleted the only-these-themes branch October 31, 2026 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope:testing Related to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a step for scenarios that need a specific set of themes

1 participant