Skip to content

Fix PHPCS errors in Behat test files - #106

Merged
swissspidy merged 1 commit into
mainfrom
fix/tests-lint
Sep 1, 2026
Merged

Fix PHPCS errors in Behat test files#106
swissspidy merged 1 commit into
mainfrom
fix/tests-lint

Conversation

@swissspidy

@swissspidy swissspidy commented Sep 1, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Tests
    • Reformatted embedded PHP test fixtures for improved readability.
    • Preserved all existing assertions and expected wp server behavior.

Copilot AI lite review requested due to automatic review settings September 1, 2026 10:35
@swissspidy
swissspidy requested a review from a team as a code owner September 1, 2026 10:35
@coderabbitai

coderabbitai Bot commented Sep 1, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: 201ed200-8acf-49a1-879b-99bacf72ea9f

📥 Commits

Reviewing files that changed from the base of the PR and between 32076f7 and a052c56.

📒 Files selected for processing (1)
  • features/server.feature

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The change reformats three embedded PHP fixtures in features/server.feature. It removes closing PHP tags and adjusts spacing in two fixtures. It expands one add_filter closure. Test assertions and expected output remain unchanged.

Changes

Server fixture formatting

Layer / File(s) Summary
Reformat embedded PHP fixtures
features/server.feature
Two mem.php fixtures use updated ini_get() spacing and omit the closing PHP tag. The HTTPS fixture uses a multi-line add_filter closure. Tested output remains unchanged.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to a052c

This is a localized formatting-only change to test fixtures, with no change to tested output or production behavior. No actionable merge-blocking risk remains after normal checks and review.

Suggested reviewers: brianhenryie, ernilambar, janw-me

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the changes. The pull request reformats Behat test fixtures to resolve PHPCS errors without changing test behavior.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/tests-lint

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the scope:testing Related to testing label Sep 1, 2026
@swissspidy swissspidy added this to the 3.0.1 milestone Sep 1, 2026
@codecov

codecov Bot commented Sep 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request updates the Behat Gherkin feature for the wp server command to resolve coding-style (PHPCS) formatting issues in embedded PHP fixtures while keeping the scenarios’ intent and assertions unchanged.

Changes:

  • Reformats the embedded mem.php fixture snippets to follow WordPress-style spacing in function calls.
  • Reformats the embedded MU-plugin fixture to a multi-line add_filter() call with WordPress-style spacing and closure formatting.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@swissspidy
swissspidy merged commit c99e63d into main Sep 1, 2026
58 checks passed
@swissspidy
swissspidy deleted the fix/tests-lint branch September 1, 2026 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope:testing Related to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants