Skip to content

Type hook callbacks to match WP_Hook::$callbacks #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
swissspidy merged 1 commit into from
Sep 2, 2026
Merged

Type hook callbacks to match WP_Hook::$callbacks #226

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 9 additions & 15 deletions src/Profiler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@
use WP_CLI;
use WP_CLI\Path;

/**
* @phpstan-type Hook_Callbacks array<int, array<string, array{function: callable, accepted_args: int}>>
*/
class Profiler {

/** @var string|false */
Expand Down Expand Up @@ -46,7 +49,7 @@ class Profiler {
private $running_hook = null;
/** @var string|null */
private $previous_filter = null;
/** @var array<mixed>|null */
/** @var Hook_Callbacks|null */
private $previous_filter_callbacks = null;
/** @var int */
private $filter_depth = 0;
Expand Down Expand Up @@ -708,31 +711,23 @@ private function set_stage_hooks( $hooks ) {
* Get the callbacks for a given filter
*
* @param string $filter
* @return array<mixed>|false
* @return Hook_Callbacks|false
*/
private static function get_filter_callbacks( $filter ) {
global $wp_filter;

if ( ! isset( $wp_filter[ $filter ] ) ) {
if ( ! isset( $wp_filter[ $filter ] ) || ! is_a( $wp_filter[ $filter ], 'WP_Hook' ) ) {
return false;
}

if ( is_a( $wp_filter[ $filter ], 'WP_Hook' ) ) {
$callbacks = $wp_filter[ $filter ]->callbacks;
} else {
$callbacks = $wp_filter[ $filter ];
}
if ( is_array( $callbacks ) ) {
return $callbacks;
}
return false;
return $wp_filter[ $filter ]->callbacks;
Comment on lines +719 to +723
}

/**
* Set the callbacks for a given filter
*
* @param string $filter
* @param mixed $callbacks
* @param string $filter
* @param Hook_Callbacks $callbacks
* @return void
*/
private static function set_filter_callbacks( $filter, $callbacks ) {
Expand All @@ -743,7 +738,6 @@ private static function set_filter_callbacks( $filter, $callbacks ) {
}

if ( is_a( $wp_filter[ $filter ], 'WP_Hook' ) ) {
/** @var array<mixed> $callbacks */
$wp_filter[ $filter ]->callbacks = $callbacks;
} else {
$wp_filter[ $filter ] = $callbacks; // phpcs:ignore
Expand Down