Skip to content

Fix empty STDIN handling in user import-csv #619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ekamran wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix empty STDIN handling in user import-csv #619

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ba2b412
Fix empty STDIN handling for user import-csv
ekamran Jun 3, 2026
15e6420
Narrow empty STDIN validation
ekamran Jun 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion features/user-import-csv.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,6 @@ Feature: Import users from CSV
| Bob Jones | contributor |
| Bill Jones | administrator,author |

@broken
Scenario: Importing users from STDIN
Given a WP install
And a users.csv file:
Expand Down
4 changes: 4 additions & 0 deletions src/User_Command.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1150,6 +1150,10 @@ public function import_csv( $args, $assoc_args ) {

$csv_data[] = $data;
}

if ( empty( $indexes ) && empty( $csv_data ) ) {
WP_CLI::error( 'Unable to read content from STDIN.' );
}
} else {
$csv_data = new CsvIterator( $filename );
}
Expand Down
Loading