Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion .oagen-manifest.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"version": 2,
"language": "node",
"generatedAt": "2026-06-01T17:59:24.986Z",
"generatedAt": "2026-06-16T16:51:34.175Z",
"files": [
"src/api-keys/interfaces/create-validation-options.interface.ts",
"src/api-keys/interfaces/delete-api-key-options.interface.ts",
Expand Down Expand Up @@ -82,6 +82,22 @@
"src/groups/serializers/index.ts",
"src/groups/serializers/update-group.serializer.ts",
"src/groups/serializers/user-organization-membership-base-list-data.serializer.ts",
"src/organization-domains/fixtures/create-organization-domain.json",
"src/organization-domains/fixtures/organization-domain.json",
"src/organization-domains/interfaces/create-organization-domain.interface.ts",
"src/organization-domains/interfaces/delete-organization-domain-options.interface.ts",
"src/organization-domains/interfaces/get-organization-domain-options.interface.ts",
"src/organization-domains/interfaces/index.ts",
"src/organization-domains/interfaces/organization-domain-state.interface.ts",
"src/organization-domains/interfaces/organization-domain-verification-strategy.interface.ts",
"src/organization-domains/interfaces/organization-domain.interface.ts",
"src/organization-domains/interfaces/verify-organization-domain-options.interface.ts",
"src/organization-domains/organization-domains.spec.ts",
"src/organization-domains/organization-domains.ts",
"src/organization-domains/serializers.spec.ts",
"src/organization-domains/serializers/create-organization-domain.serializer.ts",
"src/organization-domains/serializers/index.ts",
"src/organization-domains/serializers/organization-domain.serializer.ts",
"src/radar/fixtures/radar-list-entry-already-present-response.json",
"src/radar/fixtures/radar-standalone-assess-request.json",
"src/radar/fixtures/radar-standalone-delete-radar-list-entry-request.json",
Expand Down
8 changes: 4 additions & 4 deletions src/events/events.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -911,8 +911,8 @@ describe('Event', () => {
state: OrganizationDomainState.Pending,
domain: 'example.com',
object: 'organization_domain',
createdAt: '2026-04-06T06:24:06.749Z',
updatedAt: '2026-04-06T06:24:06.749Z',
createdAt: new Date('2026-04-06T06:24:06.749Z'),
updatedAt: new Date('2026-04-06T06:24:06.749Z'),
organizationId: 'org_01TESTORGANIZATION',
verificationStrategy: OrganizationDomainVerificationStrategy.Manual,
},
Expand Down Expand Up @@ -969,8 +969,8 @@ describe('Event', () => {
state: OrganizationDomainState.Failed,
domain: 'example.com',
object: 'organization_domain',
createdAt: '2026-03-07T02:24:56.621Z',
updatedAt: '2026-04-06T02:25:00.494Z',
createdAt: new Date('2026-03-07T02:24:56.621Z'),
updatedAt: new Date('2026-04-06T02:25:00.494Z'),
organizationId: 'org_01TESTORGANIZATION',
verificationToken: 'FAKETOKEN',
verificationStrategy: OrganizationDomainVerificationStrategy.Dns,
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
{
"domain": "foo-corp.com",
"organization_id": "org_01EHQMYV6MBK39QC5PZXHY59C3"
}

This file was deleted.

This file was deleted.

12 changes: 12 additions & 0 deletions src/organization-domains/fixtures/organization-domain.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
{
"object": "organization_domain",
"id": "org_domain_01EHZNVPK2QXHMVWCEDQEKY69A",
"organization_id": "org_01HE8GSH8FQPASKSY27THRKRBP",
"domain": "foo-corp.com",
"state": "pending",
"verification_prefix": "superapp-domain-verification-z3kjny",
"verification_token": "m5Oztg3jdK4NJLgs8uIlIprMw",
"verification_strategy": "dns",
"created_at": "2026-01-15T12:00:00.000Z",
"updated_at": "2026-01-15T12:00:00.000Z"
}
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,3 @@ export interface CreateOrganizationDomainOptions {
domain: string;
organizationId: string;
}

export interface SerializedCreateOrganizationDomainOptions {
domain: string;
organization_id: string;
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
// This file is auto-generated by oagen. Do not edit.

export interface CreateOrganizationDomain {
/** The domain to add to the organization. */
domain: string;
/** The ID of the organization to add the domain to. */
organizationId: string;
}

export interface CreateOrganizationDomainResponse {
domain: string;
organization_id: string;
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
// This file is auto-generated by oagen. Do not edit.

export interface DeleteOrganizationDomainOptions {
/** Unique identifier of the organization domain. */
id: string;
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
// This file is auto-generated by oagen. Do not edit.

export interface GetOrganizationDomainOptions {
/** Unique identifier of the organization domain. */
id: string;
}
10 changes: 9 additions & 1 deletion src/organization-domains/interfaces/index.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,11 @@
// This file is auto-generated by oagen. Do not edit.

export * from './create-organization-domain-options.interface';
export * from './organization-domain.interface';
export * from './create-organization-domain.interface';
export * from './delete-organization-domain-options.interface';
export * from './get-organization-domain-options.interface';
export * from './organization-domain-state.interface';
export * from './organization-domain-verification-failed.interface';
export * from './organization-domain-verification-strategy.interface';
export * from './organization-domain.interface';
export * from './verify-organization-domain-options.interface';
Comment on lines +1 to +11

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Non-manifest interface file may be dropped on the next oagen regeneration

interfaces/index.ts (listed in the oagen manifest) currently exports organization-domain-verification-failed.interface.ts, but that interface file itself is not in the manifest. If oagen regenerates index.ts it will only emit entries for files it tracks, silently dropping the export * from './organization-domain-verification-failed.interface' line. organization-domain-verification-failed.serializer.ts imports its types from this barrel and would fail to compile after such a regeneration. Either add the verification-failed interface to the manifest, or import it directly in the serializer rather than through the auto-generated barrel.

Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
// This file is auto-generated by oagen. Do not edit.

export enum OrganizationDomainState {
Failed = 'failed',
LegacyVerified = 'legacy_verified',
Pending = 'pending',
Unverified = 'unverified',
Verified = 'verified',
}
Comment on lines +1 to +9

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Duplicate parallel type hierarchies on the public SDK surface

OrganizationDomainState (string enum, 5 members) and OrganizationDomainStandAloneState (const object type, identical 5 members) represent the same domain concept with the same runtime string values. The same duplication exists for OrganizationDomainVerificationStrategy (enum) vs OrganizationDomainStandAloneVerificationStrategy (const type). Because TypeScript string enums are not mutually assignable with string-literal union types, code that holds the two representations side-by-side will require explicit casts, even though the underlying strings are identical. Consolidating to a single representation per concept would eliminate the ambiguity.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
// This file is auto-generated by oagen. Do not edit.

export enum OrganizationDomainVerificationStrategy {
Dns = 'dns',
Manual = 'manual',
}
Original file line number Diff line number Diff line change
@@ -1,46 +1,40 @@
export enum OrganizationDomainState {
Verified = 'verified',
Pending = 'pending',
Failed = 'failed',
}
// This file is auto-generated by oagen. Do not edit.

export enum OrganizationDomainVerificationStrategy {
Dns = 'dns',
Manual = 'manual',
}
import type { OrganizationDomainState } from './organization-domain-state.interface';
import type { OrganizationDomainVerificationStrategy } from './organization-domain-verification-strategy.interface';

export interface OrganizationDomain {
/** Distinguishes the organization domain object. */
object: 'organization_domain';
/** Unique identifier of the organization domain. */
id: string;
/** Domain for the organization domain. */
domain: string;
/** ID of the parent Organization. */
organizationId: string;
/** Domain for the organization domain. */
domain: string;
/** Verification state of the domain. */
state: OrganizationDomainState;
state?: OrganizationDomainState;
/** The prefix used in DNS verification. */
verificationPrefix?: string;
/** Validation token to be used in DNS TXT record. */
verificationToken?: string;
/** Strategy used to verify the domain. */
verificationStrategy: OrganizationDomainVerificationStrategy;
/** The prefix used in DNS verification. */
verificationPrefix?: string;
verificationStrategy?: OrganizationDomainVerificationStrategy;
/** An ISO 8601 timestamp. */
createdAt: string;
createdAt: Date;
/** An ISO 8601 timestamp. */
updatedAt: string;
updatedAt: Date;
}

export interface OrganizationDomainResponse {
object: 'organization_domain';
id: string;
domain: string;
organization_id: string;
state: OrganizationDomainState;
verification_token?: string;
verification_strategy: OrganizationDomainVerificationStrategy;
domain: string;
state?: OrganizationDomainState;
verification_prefix?: string;
verification_token?: string;
verification_strategy?: OrganizationDomainVerificationStrategy;
created_at: string;
updated_at: string;
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
// This file is auto-generated by oagen. Do not edit.

export interface VerifyOrganizationDomainOptions {
/** Unique identifier of the organization domain. */
id: string;
}
Loading