Skip to content

chore: keep lockfile registry-agnostic - #72

Merged
mjdavidson merged 1 commit into
masterfrom
chore/help-722-omit-lockfile-registry-resolved
Sep 10, 2026
Merged

mjdavidson merged 1 commit into
masterfrom
chore/help-722-omit-lockfile-registry-resolved

Conversation

@peakematt

@peakematt peakematt commented Sep 9, 2026 •

Copy link
Copy Markdown
Contributor

Public npm lockfiles should not pin registry download URLs because the install registry is environment-specific and can expose private infrastructure when serialized. This change configures omit-lockfile-registry-resolved=true so npm leaves registry-hosted resolved properties out of package-lock.json.

The regenerated lockfile removes exactly 454 registry HTTP(S) resolved properties while preserving all 454 integrity properties. Package keys, versions, dependency relationships, metadata, and non-registry resolutions are unchanged, so dependencies remain unchanged.

Verification confirmed zero semantic violations and no private registry references. git diff --check, a clean npm ci from https://registry.npmjs.org/ with a fresh cache, lint, formatting, type checking, and the production build all passed.

https://linear.app/workos/issue/HELP-722

@linear-code

linear-code Bot commented Sep 9, 2026

Copy link
Copy Markdown

HELP-722

@vercel

vercel Bot commented Sep 9, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
explore Ready Ready Preview Sep 9, 2026 9:27pm UTC

Request Review

@peakematt
peakematt marked this pull request as ready for review September 9, 2026 21:56

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@greptile-apps

greptile-apps Bot commented Sep 9, 2026

Copy link
Copy Markdown

Greptile Summary

This PR makes npm lockfile serialization registry-agnostic.

  • Adds omit-lockfile-registry-resolved=true to .npmrc.
  • Removes 454 registry-hosted resolved properties from package-lock.json.
  • Preserves package versions, dependency metadata, relationships, and integrity hashes.

Confidence Score: 5/5

The PR appears safe to merge; it changes lockfile serialization without changing the dependency graph or package integrity verification.

The base and head lockfiles are semantically identical after excluding resolved fields, all 454 deletions are registry URLs, and no actionable changed-code failure remains.

Important Files Changed

Filename Overview
.npmrc Configures supported npm versions to omit registry-hosted resolved URLs when writing lockfiles.
package-lock.json Removes only registry resolution URLs while preserving the lockfile’s dependency semantics and integrity metadata.

Reviews (1): Last reviewed commit: "chore: keep lockfile registry-agnostic" | Re-trigger Greptile

@mjdavidson
mjdavidson merged commit 75393f7 into master Sep 10, 2026
11 checks passed
@mjdavidson
mjdavidson deleted the chore/help-722-omit-lockfile-registry-resolved branch September 10, 2026 14:38

This branch was successfully deployed

1 active deployment
Preview — 8e79709b Deployed Sep 9, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants