Shrink the Jetpack migration notifications explainer asset (~4.5 MB) - #25963
Open
jkmassel wants to merge 1 commit into
Open
Shrink the Jetpack migration notifications explainer asset (~4.5 MB)#25963jkmassel wants to merge 1 commit into
jkmassel wants to merge 1 commit into
Conversation
The wp-migration-notifications-explainer-{ltr,rtl} imagesets shipped as
Figma-exported PDFs that each embed a 1960x1408 raster, but the illustration
renders at its intrinsic ~204pt in a center-aligned, aspect-fit stack. Replace
the four oversized PDFs (4.95MB) with @2x/@3x PNGs rendered at the display size
(416KB total) — a ~4.5MB uncompressed reduction with no visible change.
Collaborator
Generated by 🚫 Danger |
Contributor
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 34115 | |
| Version | PR #25963 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 15b0d6d | |
| Installation URL | 2t1q2qeuqmeoo |
Contributor
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 34115 | |
| Version | PR #25963 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 15b0d6d | |
| Installation URL | 0s2m4ta24n8qg |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
wp-migration-notifications-explainer-{ltr,rtl}PDFs with correctly-sized@2x/@3xPNGs.Root Cause
The imagesets were exported from Figma as PDFs that each embed a 1960×1408 raster — they aren't real vector art. The illustration renders at its intrinsic ~204 pt in a center-aligned,
.scaleAspectFitstack (MigrationNotificationsCenterView→MigrationCenterView), so the shipped raster is ~10× oversized by area. It was the single largest asset in the project; the next-biggest catalog PDF is 428 KB.Fix
Rendered each PDF to
@2x(408×270) and@3x(612×405) PNGs at the display size and updated bothContents.json. No@1xvariant — the minimum deployment target is iOS 17, so there are no@1xdevices. The code references the imageset name (UIImage(named: "wp-migration-notifications-explainer-ltr")), which is unchanged.Test Plan
actoolcompiles the catalog cleanly; both renditions present in the resultingAssets.car.@3xPNG is pixel-faithful to the source PDF (light + dark).Notes
This is the low-risk, byte-only step. The screen it feeds is part of the winding-down WordPress→Jetpack migration flow (see #25877, #25879). Removing the screen outright is a separate follow-up — it carries a live side-effect (
JetpackNotificationMigrationService.rescheduleLocalNotifications()has no other trigger in the Jetpack app) that would need to move onto the silent-import path, so it should go through the migration-flow owner rather than ride in on an asset resize.