Update wordpress:utils 3.5.0 -> 3.15.0#1119
Conversation
|
@zwarm It looks like you are the most recent contributor to this project. Can you help land this PR? |
Hi @ygnessin, thanks for the contribution! I’ll need to take a deeper look at how this change could impact the apps currently using this library before moving forward. The utils haven’t been updated since 2024, and quite a bit has changed since then. This review may take some time as I’m currently focused on higher-priority work, but I’ll share an update as soon as I’m able to dig in. 🙇 |
zwarm
left a comment
There was a problem hiding this comment.
Thanks for the contribution — removing the GET_ACCOUNTS permission bleed is a worthwhile fix!
A few things before this merges:
1. Changelog review
This jumps 10 minor versions (3.5.0 → 3.15.0). Could you skim the WordPress-Utils-Android releases for any behavioral changes or deprecations in the classes Aztec uses (AppLog, ImageUtils, PermissionUtils, ToastUtils, DeviceUtils) and confirm nothing breaks?
2. Transitive dependency check
The main goal is removing GET_ACCOUNTS — worth verifying no new permissions or unexpected transitive dependencies were introduced in the process. You can check with:
./gradlew :aztec:dependencies
A before/after diff of the output would be ideal.
3. Manual smoke test on the demo app
Unit tests passing is great. Since ImageUtils is used in real image-handling paths, a quick manual pass on image insertion in the demo app would help confirm nothing regressed there.
I think the only thing of note is Beyond that, I am relying on the semantic versioning policy of the library which indicates that a minor version bump shouldn't contain breaking changes.
Here you go: https://gist.github.com/ygnessin/e7553f7285056dd29edfdae403f61434
Works!
|

Fix
Updates the
wordpress:utilsdependency to the latest: https://github.com/wordpress-mobile/WordPress-Utils-Android/releasesPrimary motivation is that the GET_ACCOUNTS permission gets pulled into any apps using Aztec. This was fixed in version 3.8.0 of
wordpress:utils.Many other dependencies are severely out of date as well, hopefully there is a plan to update them at some point.
Test
Ran all unit tests and they passed
Review
??? Not sure