Repository navigation
harden error queue and GMULT cases, add force zero to ColdFire DES port - #12001
JacobBarthelmeh wants to merge 5 commits into
Conversation
|
There was a problem hiding this comment.
🟡 Changes recommended
Process-global error snapshots still permit data races and mismatched diagnostics, while new test assertions fail in Windows debug/OpenSSL-extra builds with the error queue disabled.
2 open issues
What changed in this PR
This PR hardens wolfSSL’s error-queue handling and cryptographic internals by addressing stale pointers, removing data-dependent branches, and clearing temporary key material.
Changes:
- Copy exported error strings, reset queue cursors during cleanup, and add regression tests.
- Replace conditional XOR operations with masking in GCM and GCM-SIV multiplication paths.
- Zero temporary key material after ColdFire DES operations.
| File | Description |
|---|---|
wolfcrypt/src/logging.c |
Adds error-string snapshots and resets cursors when clearing queues. |
wolfcrypt/src/des3.c |
Clears the ColdFire DES temporary key buffer. |
wolfcrypt/src/aes.c |
Uses branchless masking in selected multiplication paths. |
tests/api.c |
Adds queue-reset and returned-string lifetime checks. |
Review effort: Balanced
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #12001
Scan targets checked: wolfcrypt-src, wolfcrypt-bugs, wolfssl-bugs
Coverage: 4 of 4 in-scope changed file(s) opened by the reviewer
Findings: 1
1 finding(s) posted as inline comments (see file-level comments below)
This review was generated automatically by Fenrir. Reported findings require changes before merge.
Review tier: Max
b3ab095 to
42fcdbe
Compare
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #12001
Error: TimeoutExpired


No description provided.