Update wolfSSL version in ML-KEM and Thread tests#984
Open
ejohnstown wants to merge 1 commit into
Open
Conversation
Contributor
ejohnstown
commented
May 15, 2026
- Update WOLFSSL_REF to v5.9.1-stable in the ML-KEM and single-thread tests (interop-mlkem.yml, singlethread-check.yml).
- Drop kyber.yml; its coverage is a strict subset of interop-mlkem.yml. Fold its push and workflow_dispatch triggers into interop-mlkem.yml so ML-KEM still runs on master/release pushes and via manual dispatch.
- Drop liboqs from the ML-KEM test. It isn't in configure.ac any more.
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #984
No scan targets match the changed files in this PR. Review skipped.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the GitHub Actions CI coverage for ML-KEM and single-thread testing by pinning wolfSSL to a newer stable tag, consolidating redundant ML-KEM workflows, and removing liboqs usage from the ML-KEM CI path.
Changes:
- Bump
WOLFSSL_REFtov5.9.1-stablefor ML-KEM interop and single-thread CI workflows. - Remove
kyber.ymland fold itspush/workflow_dispatchtriggers intointerop-mlkem.yml. - Simplify the ML-KEM interop workflow to use a single wolfSSL ref instead of a wolfSSL version matrix.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .github/workflows/singlethread-check.yml | Pins single-thread CI to wolfSSL v5.9.1-stable. |
| .github/workflows/kyber.yml | Removes the redundant ML-KEM workflow (coverage now handled by interop-mlkem.yml). |
| .github/workflows/interop-mlkem.yml | Adds push/workflow_dispatch triggers, pins wolfSSL to v5.9.1-stable, and removes the prior wolfSSL version matrix. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
1. Update WOLFSSL_REF to v5.9.1-stable in the ML-KEM and single-thread tests (interop-mlkem.yml, singlethread-check.yml). 2. Drop kyber.yml; its coverage is a strict subset of interop-mlkem.yml. Fold its push and workflow_dispatch triggers into interop-mlkem.yml so ML-KEM still runs on master/release pushes and via manual dispatch. 3. Drop liboqs from the ML-KEM test. It isn't in configure.ac any more.
c69ece2 to
7f08f69
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.