Revert "add macro guard on SHA512 hashType"#370
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reverts the SHA-512 hashType macro-guard changes, restoring unconditional SHA-512 async/DMA test execution and unconditional wc_Sha512.hashType access in the server DMA path.
Changes:
- Removes
WOLFSSL_SHA512_HASHTYPEguards around SHA-512 async tests. - Removes the test build option and CI job for SHA-512 without
WOLFSSL_SHA512_HASHTYPE. - Restores unconditional SHA-512 DMA server
hashTypeassignment.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
test/wh_test_crypto.c |
Enables SHA-512 async and DMA async tests under WOLFSSL_SHA512 only. |
test/Makefile |
Removes NO_SHA512_HASHTYPE test define support. |
test/config/user_settings.h |
Always defines WOLFSSL_SHA512_HASHTYPE. |
src/wh_server_crypto.c |
Restores unconditional sha512->hashType assignment in SHA-512 DMA handling. |
.github/workflows/build-and-test.yml |
Removes CI coverage for DMA without WOLFSSL_SHA512_HASHTYPE. |
Comments suppressed due to low confidence (1)
test/wh_test_crypto.c:11308
- This DMA SHA-512 async test is now enabled for any WOLFSSL_SHA512 build, but the DMA client functions it calls are only compiled when WOLFSSL_SHA512_HASHTYPE is also defined. A DMA build with SHA-512 but without that macro will fail to link (and the server DMA path also cannot compile because wc_Sha512 lacks hashType).
#ifdef WOLFHSM_CFG_DMA
if (ret == WH_ERROR_OK) {
ret = whTest_CryptoSha512DmaAsync(client, WH_DEV_ID_DMA, rng);
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bigbrett
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #357