Skip to content

Revert "add macro guard on SHA512 hashType"#370

Merged
bigbrett merged 1 commit into
mainfrom
revert-357-build
May 15, 2026
Merged

Revert "add macro guard on SHA512 hashType"#370
bigbrett merged 1 commit into
mainfrom
revert-357-build

Conversation

@JacobBarthelmeh
Copy link
Copy Markdown
Contributor

Reverts #357

@JacobBarthelmeh JacobBarthelmeh self-assigned this May 15, 2026
Copilot AI review requested due to automatic review settings May 15, 2026 21:10
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reverts the SHA-512 hashType macro-guard changes, restoring unconditional SHA-512 async/DMA test execution and unconditional wc_Sha512.hashType access in the server DMA path.

Changes:

  • Removes WOLFSSL_SHA512_HASHTYPE guards around SHA-512 async tests.
  • Removes the test build option and CI job for SHA-512 without WOLFSSL_SHA512_HASHTYPE.
  • Restores unconditional SHA-512 DMA server hashType assignment.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
test/wh_test_crypto.c Enables SHA-512 async and DMA async tests under WOLFSSL_SHA512 only.
test/Makefile Removes NO_SHA512_HASHTYPE test define support.
test/config/user_settings.h Always defines WOLFSSL_SHA512_HASHTYPE.
src/wh_server_crypto.c Restores unconditional sha512->hashType assignment in SHA-512 DMA handling.
.github/workflows/build-and-test.yml Removes CI coverage for DMA without WOLFSSL_SHA512_HASHTYPE.
Comments suppressed due to low confidence (1)

test/wh_test_crypto.c:11308

  • This DMA SHA-512 async test is now enabled for any WOLFSSL_SHA512 build, but the DMA client functions it calls are only compiled when WOLFSSL_SHA512_HASHTYPE is also defined. A DMA build with SHA-512 but without that macro will fail to link (and the server DMA path also cannot compile because wc_Sha512 lacks hashType).
#ifdef WOLFHSM_CFG_DMA
    if (ret == WH_ERROR_OK) {
        ret = whTest_CryptoSha512DmaAsync(client, WH_DEV_ID_DMA, rng);

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/wh_server_crypto.c
Comment thread test/wh_test_crypto.c
Comment thread .github/workflows/build-and-test.yml
Comment thread test/config/user_settings.h
Comment thread test/Makefile
@JacobBarthelmeh JacobBarthelmeh marked this pull request as ready for review May 15, 2026 21:20
@bigbrett bigbrett merged commit 5f5a59d into main May 15, 2026
112 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants