[boards] Fix off-by-one in SysTick cyclesPerTick#40
Open
SAY-5 wants to merge 1 commit into
Open
Conversation
Member
|
Hey @SAY-5, Thank you so much for the contribution. I just merged some changes that caused some conflicts in your PR. The SysTick device initialization has moved to the board.h instead of the board.c now so it should be a quick fix for you. Also, prior to merging this you will need to sign the wolfSSL contributor agreement. It's a quick process, just send an email to support at wolfssl dot com to get started. Please include this PR number and tell us about your project! |
ad47719 to
d5b5b02
Compare
Author
|
Thanks for the heads up. Rebased onto main and moved the off-by-one fix into the WHAL_CFG_SYSTICK_DEV macro in each board.h. I'll email support to get the contributor agreement signed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #38.
Cortex-M SysTick reloads every
LOAD + 1cycles, socyclesPerTickmust beclock / ticks_per_second - 1to produce the intended period. All ten board configs were one cycle high, causing the 1 kHz tick to run slightly slow.Applied the maintainer-suggested fix (subtract 1 in each board config) rather than baking the offset into
systick.c, to preserve the "cyclesPerTick" naming and keep RVR writes literal.