Repository navigation
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the release-tarball packaging and validation changes.
No open issues 🎉
What changed in this PR
This PR makes release tarballs include the files needed to build tests and examples and run certificate-based demos, addressing F-16526.
Changes:
- Adds example sources, test credentials, and missing test support files to
EXTRA_DIST. - Enables tests during
make distcheckand runs it in the autoconf CI job. - Documents tarball validation and clarifies that test credentials must never be deployed.
| File | Description |
|---|---|
| Makefile.am | Includes missing distribution files and enables tests for distcheck. |
| docs/CI.md | Documents release-tarball validation in CI. |
| AGENTS.md | Changes the test-credential warning from shipping to deployment. |
| .github/workflows/pr.yml | Runs autoconf distcheck and prints logs on failure. |
Review effort: Balanced
|
@claude review |
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #67
Scan targets checked: wolfcert-pr-general
Review type: general (no scan target covers the changed files)
Coverage: 2 of 4 in-scope changed file(s) opened by the reviewer; not opened: AGENTS.md, docs/CI.md
Fenrir result: Approved ✅
No new issues found in the changed files.
Advisory only — this automated result does not count as a GitHub approval.
Review tier: Max
yosuke-wolfssl
left a comment
There was a problem hiding this comment.
LGTM.
Please rebase onto main to make Zephyr job green.
EXTRA_DIST left out examples/certs, tests/test_static_mem.h, tests/CMakeLists.txt and the examples. From a release tarball, ./configure --enable-tests failed to compile (most unit tests include ../test_static_mem.h), CMake with tests or examples on stopped at the missing subdirectory, and the Zephyr EST sample and test, the host server for the Zephyr test and the README CLI demo lacked the credentials they load from examples/certs. List each tracked file rather than the directories, so a stray local file never ships, and have make distcheck configure with --enable-tests so a test file missing from EXTRA_DIST fails it. The autoconf PR job now runs make distcheck, which keeps that check from going stale. The certs are throwaway test credentials, so the AGENTS.md row now says never deploy them rather than never ship them. The autoconf build now builds the examples too: --enable-examples was accepted but built nothing. They are noinst programs gated on EST and SCEP as in examples/CMakeLists.txt, automake ships their sources, and make distcheck also configures with --enable-examples, so the PR job compiles them from the tarball. No CI job built them before; the cmake-full-werror job now does too, so a warning in an example fails it. .gitignore covers the binaries of an in-tree autoconf build. Fixes F-16526.
|
@yosuke-wolfssl done, CI is fully green now. Thanks! |
make distleft outexamples/certs/, the examples,tests/CMakeLists.txtandtests/test_static_mem.h, so a release tarball could not build the tests with either build system or the examples with CMake, nor run the Zephyr sample or the README CLI demo. Autoconf never built the examples at all:--enable-exampleswas a no-op.Changes
examples/andtests/test_static_mem.h,tests/CMakeLists.txtinEXTRA_DIST--enable-examples, gated on EST/SCEP as in CMakemake distcheckconfigures with--enable-tests --enable-examples.gitignorecovers the in-tree autoconf example binariesTesting
autoconf-fullPR job now runsmake distcheck, which builds the tests and examples from the tarball and runs the testscmake-full-werrorbuilds the examples with-WerrorFixes F-16526.