fix(Chip): expose selected prop to screen readers via accessibilityState#4023
Closed
adids1221 wants to merge 4 commits into
Closed
fix(Chip): expose selected prop to screen readers via accessibilityState#4023adids1221 wants to merge 4 commits into
adids1221 wants to merge 4 commits into
Conversation
Adds a Claude Code skill for react-native-ui-lib users. Includes: - Component lookup via node_modules api.json files (batched, fast) - Layout-to-component mapping table - Styling guide: modifiers, spacing, design tokens, typography, shadows - Component intelligence: intent classification, discovery loop, props triage - Getting started: install, peer deps, ThemeManager setup - Theming guide: Colors, Typography, Spacings, ThemeManager overrides Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Adds install-skills.js at the package root — copies the uilib-codegen skill into .claude/skills/ in the user's project. Usage: node node_modules/react-native-ui-lib/install-skills.js Also adds skills/ and install-skills.js to the package.json files field so they are included in the npm publish. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
✅ PR Description Validation PassedAll required sections are properly filled out:
Your PR is good for review! 🚀 This validation ensures all sections from the PR template are properly filled. |
Contributor
Author
|
Closing in favor of #4024 which contains only the Chip accessibility fix, without the unrelated skills changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
Chipcomponent had no way to communicate selection state to screen readers.Passing
accessibilityStatevia spread worked as a workaround but was undocumented and fragile.Added
selectedas a first-class optional prop — when provided, it maps directly toaccessibilityState={{selected}}on the container.When omitted, behavior is identical to today.
Changelog
Chip - Added
selectedprop that exposes selection state to screen readers viaaccessibilityState.Additional info
N/A