Skip to content

[WPB-23765] Refresh ES index after app update, emit event.#5231

Open
fisx wants to merge 5 commits into
developfrom
WPB-23765-refresh-es-index-after-app-update_-emit-event
Open

[WPB-23765] Refresh ES index after app update, emit event.#5231
fisx wants to merge 5 commits into
developfrom
WPB-23765-refresh-es-index-after-app-update_-emit-event

Conversation

@fisx
Copy link
Copy Markdown
Contributor

@fisx fisx commented May 15, 2026

https://wearezeta.atlassian.net/browse/WPB-23765

updating apps did not refresh the user index and did not send the user-update event. this is now fixed.

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label May 15, 2026
@fisx fisx force-pushed the WPB-23765-refresh-es-index-after-app-update_-emit-event branch from c5e1b0a to 731954e Compare May 15, 2026 15:24
@fisx fisx marked this pull request as ready for review May 15, 2026 15:24
@fisx fisx requested review from a team as code owners May 15, 2026 15:24
Copy link
Copy Markdown
Contributor

@battermann battermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only 2 nit-picks

<$> (resp.json %. "user")
<*> (resp.json %. "user.id")

let Object appMetadata =
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this deconstruction necessary? If we remove it we do not have to reconstruct it later in line 247, maybe?

Comment thread integration/test/Notifications.hs Outdated
@fisx fisx force-pushed the WPB-23765-refresh-es-index-after-app-update_-emit-event branch from e281b3e to 84cd1bc Compare May 18, 2026 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants