fix: prevent autofill crash before text field layout - #5197
Open
Garzas wants to merge 1 commit into
Open
Conversation
Contributor
Test Results2 265 tests 2 265 ✅ 2m 58s ⏱️ Results for commit 4e83b53. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
The application could crash while navigating to an authentication screen containing an autofill-enabled text field.
The observed exception was:
IllegalStateException: requestAutofill called before onChildPositioned()Causes
The legacy Compose autofill implementation manually created and registered
AutofillNodeinstances. Autofill could be requested when a field received focus before its position had been calculated.Several authentication screens also manually cleared the global autofill tree during composition, making the autofill lifecycle more fragile.
Solutions
AutofillNodemanagement with ComposeContentTypemodifiers.BasicTextFieldandBasicSecureTextField.