feat: Display viewer only banner on shared drive and conversation (WPB-26394) - #5193
Open
ohassine wants to merge 2 commits into
Open
feat: Display viewer only banner on shared drive and conversation (WPB-26394)#5193ohassine wants to merge 2 commits into
ohassine wants to merge 2 commits into
Conversation
…y-banner-on-Shared-drive-and-conversation # Conflicts: # core/ui-common/src/main/res/drawable/ic_close.xml # features/cells/src/main/java/com/wire/android/feature/cells/ui/CellsViewModelFactory.kt
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (50.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #5193 +/- ##
===========================================
- Coverage 52.19% 52.19% -0.01%
===========================================
Files 668 669 +1
Lines 23972 23999 +27
Branches 3950 3954 +4
===========================================
+ Hits 12512 12526 +14
- Misses 10300 10310 +10
- Partials 1160 1163 +3
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Contributor
Test Results2 267 tests 2 267 ✅ 2m 49s ⏱️ Results for commit f547ba6. ♻️ This comment has been updated with latest results. |
ohassine
requested review from
saleniuk and
sbakhtiarov
and removed request for
sbakhtiarov
August 20, 2026 11:53
saleniuk
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-26394
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Description:
Display viewer-only banner on Shared drive and conversation
In shared drive, if user closes the banner, it won't show up again.
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.