Skip to content

feat: Display viewer only banner on shared drive and conversation (WPB-26394) - #5193

Open
ohassine wants to merge 2 commits into
developfrom
Display-viewer-only-banner-on-Shared-drive-and-conversation
Open

feat: Display viewer only banner on shared drive and conversation (WPB-26394)#5193
ohassine wants to merge 2 commits into
developfrom
Display-viewer-only-banner-on-Shared-drive-and-conversation

Conversation

@ohassine

@ohassine ohassine commented Aug 19, 2026

Copy link
Copy Markdown
Member

https://wearezeta.atlassian.net/browse/WPB-26394


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Description:

Display viewer-only banner on Shared drive and conversation
In shared drive, if user closes the banner, it won't show up again.

Screenshot_20260819_174120

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

…y-banner-on-Shared-drive-and-conversation

# Conflicts:
#	core/ui-common/src/main/res/drawable/ic_close.xml
#	features/cells/src/main/java/com/wire/android/feature/cells/ui/CellsViewModelFactory.kt
@codecov

codecov Bot commented Aug 19, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.19%. Comparing base (10f530d) to head (f547ba6).

Files with missing lines Patch % Lines
...roid/feature/cells/data/ViewerAccessBannerStore.kt 0.00% 8 Missing ⚠️
...com/wire/android/feature/cells/ui/CellViewModel.kt 70.00% 3 Missing and 3 partials ⚠️

❌ Your patch check has failed because the patch coverage (50.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5193      +/-   ##
===========================================
- Coverage    52.19%   52.19%   -0.01%     
===========================================
  Files          668      669       +1     
  Lines        23972    23999      +27     
  Branches      3950     3954       +4     
===========================================
+ Hits         12512    12526      +14     
- Misses       10300    10310      +10     
- Partials      1160     1163       +3     
Files with missing lines Coverage Δ
.../ui/home/messagecomposer/EnabledMessageComposer.kt 0.00% <ø> (ø)
...com/wire/android/feature/cells/ui/CellViewModel.kt 50.00% <70.00%> (+1.20%) ⬆️
...roid/feature/cells/data/ViewerAccessBannerStore.kt 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10f530d...f547ba6. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

github-actions Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Test Results

2 267 tests   2 267 ✅  2m 49s ⏱️
  250 suites      0 💤
  250 files        0 ❌

Results for commit f547ba6.

♻️ This comment has been updated with latest results.

@ohassine
ohassine requested review from saleniuk and sbakhtiarov and removed request for sbakhtiarov August 20, 2026 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants