Skip to content

fix: mls group creation recovery [WPB-27337] - #5191

Open
Garzas wants to merge 2 commits into
developfrom
fix/mls-group-creation-recovery
Open

fix: mls group creation recovery [WPB-27337]#5191
Garzas wants to merge 2 commits into
developfrom
fix/mls-group-creation-recovery

Conversation

@Garzas

@Garzas Garzas commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

https://wearezeta.atlassian.net/browse/WPB-27337


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

When MLS group establishment fails after the backend conversation has already been created, Android displays a generic error. Starting the creation flow again can create a duplicate conversation.

Causes

Android did not retain the pending conversation ID and treated the MLS establishment failure like a complete conversation creation failure.

Solutions

  • Keep the pending conversation ID after an MLS establishment failure.
  • Show a dedicated dialog explaining that the conversation is not ready yet.
  • Allow the user to retry using the existing conversation instead of creating another one.
  • Allow the user to close the flow while recovery continues through Kalium.
  • Retry MLS establishment when the user opens a visible PENDING_CREATION conversation.
  • Prevent repeated retries within the same conversation ViewModel instance.
  • Add automated tests for the dialog state, manual retry and retry after opening a pending conversation.

@Garzas Garzas self-assigned this Aug 19, 2026
@Garzas
Garzas requested a review from saleniuk August 19, 2026 11:50
@Garzas
Garzas force-pushed the fix/mls-group-creation-recovery branch from 3e9502a to 5e6c380 Compare August 19, 2026 11:53
@codecov

codecov Bot commented Aug 19, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.90909% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.27%. Comparing base (10f530d) to head (5e6c380).

Files with missing lines Patch % Lines
...i/home/newconversation/NewConversationViewModel.kt 91.11% 1 Missing and 3 partials ⚠️
...me/conversations/info/ConversationInfoViewModel.kt 90.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5191      +/-   ##
===========================================
+ Coverage    52.19%   52.27%   +0.07%     
===========================================
  Files          668      668              
  Lines        23972    24021      +49     
  Branches      3950     3960      +10     
===========================================
+ Hits         12512    12556      +44     
- Misses       10300    10301       +1     
- Partials      1160     1164       +4     
Files with missing lines Coverage Δ
...me/conversations/info/ConversationInfoViewModel.kt 81.31% <90.00%> (+1.07%) ⬆️
...i/home/newconversation/NewConversationViewModel.kt 72.59% <91.11%> (+3.95%) ⬆️

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10f530d...5e6c380. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

Copy link
Copy Markdown
Contributor

Test Results

2 271 tests   2 271 ✅  2m 31s ⏱️
  250 suites      0 💤
  250 files        0 ❌

Results for commit 5e6c380.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants