Skip to content

feat(session): add database preparation boundary PR 1 - #5158

Open
MohamadJaara wants to merge 2 commits into
developfrom
mo/async-db-migration/01-foundation
Open

feat(session): add database preparation boundary PR 1#5158
MohamadJaara wants to merge 2 commits into
developfrom
mo/async-db-migration/01-foundation

Conversation

@MohamadJaara

Copy link
Copy Markdown
Member

Goal

Add the Android boundary for Kalium's explicit user-session database preparation lifecycle.

Changes

  • update the Kalium pointer to the preparation API implementation
  • add a single Android preparation gate and explicit success/failure mapping
  • cover shared preparation, scope reuse, and retryability with focused tests

Impact

This is a foundation-only change. It introduces no screen or consumer behavior yet; later PRs use this boundary before accessing a user database.

Stack

  • Epic branch: mo/epic/async-db-migration
  • PR 1 of 7

@MohamadJaara
MohamadJaara changed the base branch from mo/epic/async-db-migration to develop August 18, 2026 12:27
@MohamadJaara
MohamadJaara force-pushed the mo/async-db-migration/01-foundation branch 2 times, most recently from c6f2da8 to 0f4d4ce Compare August 18, 2026 12:45
@github-actions

github-actions Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Test Results

2 274 tests  +3   2 274 ✅ +3   2m 44s ⏱️ +58s
  251 suites +1       0 💤 ±0 
  251 files   +1       0 ❌ ±0 

Results for commit 8bacfda. ± Comparison against base commit 221865e.

♻️ This comment has been updated with latest results.

@MohamadJaara
MohamadJaara force-pushed the mo/async-db-migration/01-foundation branch from 0f4d4ce to 4b3b751 Compare August 19, 2026 11:49
@MohamadJaara
MohamadJaara force-pushed the mo/async-db-migration/01-foundation branch from 4b3b751 to 9c397c4 Compare August 21, 2026 09:55
@github-actions

Copy link
Copy Markdown
Contributor

@MohamadJaara looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

develop This PR
b6b73047c2589b0dd51d86524f07a42e5edeafd0 4106bc6ace0f69781c5212ce7f6d712fae4c0d5a

Is this intentional?

@codecov

codecov Bot commented Aug 21, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 52.24%. Comparing base (221865e) to head (8bacfda).

Files with missing lines Patch % Lines
...wire/android/session/UserSessionPreparationGate.kt 92.85% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5158      +/-   ##
===========================================
+ Coverage    52.21%   52.24%   +0.02%     
===========================================
  Files          668      669       +1     
  Lines        23987    24001      +14     
  Branches      3952     3955       +3     
===========================================
+ Hits         12526    12539      +13     
- Misses       10301    10302       +1     
  Partials      1160     1160              
Files with missing lines Coverage Δ
...wire/android/session/UserSessionPreparationGate.kt 92.85% <92.85%> (ø)

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 221865e...8bacfda. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

Copy link
Copy Markdown
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants