API draft for the rewrite

[oskardotglobal]

This PR is a draft for how the API of the rewrite could look like.
There are no implementations yet, but once the API is stable the implementations for features can gradually be put in place.

The main difference between the design of legacy WinApps is that the config is the single source of truth for installed apps and will later also contain paths to the icons for the installed apps, meaning we can get rid of the "pre-configured" apps currently found in the apps folder. A sample config would look like this:

[auth]
username = "Docker"
password = ""
ssh_port = 2222
rdp_port = 3390
domain = ""

[container]
enable = true
enable_podman = false
container_name = "WinApps"

[libvirt]
enable = false
vm_name = "RDPWindows"

[manual]
enable = false
host = "127.0.0.1"

[freerdp]
extra_args = [
    "/cert:ignore",
    "+auto-reconnect",
    "+span",
]
executable = "xfreerdp"

[linked_apps.explorer]
name = "Explorer"
win_exec = "explorer.exe"

# [linked_apps.<...>]
# name = ...

Disclaimer: I've used LLMs for planning purposes ("diffing" the rewrite with the legacy version) and to help decide where mocking for e2ee testing makes sense. However, all the code was written by me.

TODOs

• Libvirt implementation
• Basic app detection
• Uninstalling apps
• Changing the RDP port
• Loading apps from multiple files / a well-defined folder / ... so we can better ship pre-defined apps
• podman unshare support
• MIME type support
• port improved app detection
• ms office URL handlers
• RDP_SCALE
• autopausing
• different flags for desktop and app mode
• improved freerdp discovery

[oskardotglobal]

I've been working on this and there are still some implementations and features missing, but as far as the API goes I think it's pretty good.

This is currently still missing the entire libvirt implementation as well as the MULTIMON and SCALE config settings and the app detection, which doesn't even have a proper Api yet.

However, the connection check using a TcpStream should already be more stable than the simple check using Netcat, so I think there's a lot of value to be had here once this is more feature-complete.

[LDprg]

This seems great (just a quick look, no proper review). I didn't checked the repo in a while (as written before I sadly lack time to work on winapps at the moment). Didn't expect this to be that far.

[oskardotglobal]

Ok, I've had some more time to work on this.

The libvirt implementation is still missing, but I'm working towards apps now. The most notable change is the addition of a custom docker image, which already includes the OEM files. The install script has also been changed to now set up an SSH server automatically, which I'll be using for discovering the apps.

This means that basically every feature from the winapps script itself is implemented, I just need the installer logic now; so this should be ready for review soon.

[oskardotglobal]

Thanks, git

[oskardotglobal]

Right, rebasing to sign off commits broke history, so I had to scrap all of it, forcing me to squash everything into one commit. Sorry about that.

[LDprg]

Great work @oskardotglobal!
I made a quick review for now (I think we will need to do this in multiply cycles because of the PR size).

I don't know what I should think of those AI reviews. I dislike the thought of AI companies making money of open source projects without asking the developers/maintainers.

[LDprg]

We should update the packages to latest and switch from edition="2021" to edition="2024".
Also switching to rust workspaces would help alot.

[oskardotglobal]

I've addressed some of your comments. Regarding the AI review, I triggered that myself; I wanted to try it. I honestly can't argue against the quality; it was pretty good. There are settings which auto-generate PR summaries and auto-review PRs which I find to be too intrusive, but if triggered manually I think it could be useful. We should have a discussion about an AI policy for our project, though.

[LDprg]

A first test resulted in following issues:

• the default config seems to throw an error about manual.host
• if the winapps throws an error you cannot show the help menu
• the default docker credentials should be the default ones in the config

Great work on the error management, btw!

[LDprg]

I did a quick dirty review. Seems all fine to me (however no testing on my side).

Sry for the late review (I am currently very busy).

[oskardotglobal]

No problem. I still have some stuff i'd like to implement (unit tests, better freerdp binary discovery) before this is ready for a full review.