feat: add named vitest instances - #107
Conversation
commit: |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5c4c357e20
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const host = instance.host.includes(':') ? instance.host : '0.0.0.0' | ||
| const { port = await getPort({ host }) } = options |
There was a problem hiding this comment.
When an instance advertises a hostname that resolves to IPv6, such as localhost on an IPv6-first system, this branch probes only 0.0.0.0. A port already occupied by an IPv6-only listener can therefore be selected and then fail with EADDRINUSE when the instance binds the hostname. Probe both address families for hostnames, rather than treating every host without a colon as IPv4-only.
Useful? React with 👍 / 👎.
1 participant
Added named
instancesto VitestServer.setupandPool.setupfor multiple isolated instances per worker, with independent lifecycle controls and cleanup. Preserved the single-instance API.