feat: add bootstrapped Tempo localnet instance - #105
Conversation
commit: |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 91dba3951f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| pnpm test --bail=1 \ | ||
| --exclude src/instances/alto.test.ts \ | ||
| --testNamePattern="^(?!.*instance: alto)(?!.*instance: 'alto')" |
There was a problem hiding this comment.
Avoid loading forked suites when the RPC secret is absent
When VITE_FORK_URL is unavailable, this name filter skips the Alto test bodies but does not prevent their files' module-level setup from running: src/Pool.test.ts and src/Server.test.ts both start a forked Anvil before tests are filtered. Those suites therefore still contact the public fallback RPC and can fail or be rate-limited before the skipped tests are considered, so the no-secret CI path remains externally fork-dependent; make those setup hooks conditional or refactor/exclude the fork-dependent suites themselves.
Useful? React with 👍 / 👎.
| uses: ./.github/actions/install-dependencies | ||
|
|
||
| - name: Run Tempo localnet tests | ||
| run: pnpm test --run src/testcontainers/tempoLocalnet.test.ts |
There was a problem hiding this comment.
could be nice to setup vitest projects so we can exclude (like alto) or run specifics suite like tempo localnet more easily. (can do some other time so we can get this out.)
Motivation
Consumers need a reusable Testcontainers instance for Tempo’s fully bootstrapped localnet image without recreating node setup.
Summary
Instance.tempoLocalnetwith health-based readiness and dynamic host portsKey design considerations
Instance.tempopath for custom node and hardfork setups