Conversation
npx mint validate resolved latest on every run; a broken upstream publish then failed unrelated merges (ETARGET @mintlify/common). The committed docs/package-lock.json pins the full dependency tree, so CI resolves nothing from live npm metadata. Dependabot now owns bump PRs via the npm /docs ecosystem entry.
|
ⓘ Qodo reviews are paused because your trial has ended. Ask your workspace admin to add credits to resume reviews. Manage billing |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Warning Review limit reachedNext included review available in 32 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (3)
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (4)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe docs package pins the Mintlify CLI and defines its scripts. Docs validation now installs dependencies from the lockfile and runs the package validation script. Dependabot checks npm dependencies in ChangesDocs validation
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: Merge Risk: ⚪ Minimal · up to Docs validation uses the locked dependencies from the intended directory and is ready to merge after normal checks. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
mint@4.2.923 has no build command (Unknown command: build, exit 1); strict validation is mint validate, which CI already runs. Production builds happen server-side via the Mintlify GitHub app.
Fixes #110
TL;DR
Docs Validationresolvesmint(and its whole dependency tree) from live npm metadata on every run, so a broken upstream publish fails unrelated merges — seen on upstreammainwhere a merged commit failed withETARGET @mintlify/common@1.0.1165while all 13 other checks passed. This PR makes the job resolve nothing at run time: manifest + committed lockfile +npm ci.Files (5, +14.7k / -1 — all but ~20 lines are the generated lockfile):
docs/package-lock.jsonnpm cidoes zero run-time resolution.docs/package.json(small, read this one)mint@4.2.923pinned as devDependency + scripts (dev,build,validate,broken-links)..github/workflows/test.ymlnpm ci && npm run validate;setup-nodegainscache: npm;PUPPETEER_SKIP_DOWNLOAD=1(chrome only needed bymint dev/broken-links)..github/dependabot.ymlnpmecosystem entry for/docs— bump PRs update manifest + lockfile together, weekly, grouped like the existing ecosystems..gitignore/docs/node_modules/next to the dashboard entry.Dependabot wiring
Included directly in this PR, not a follow-up: the new
npm/docsecosystem picks updocs/package-lock.jsonand owns futuremintbumps the same waygomod/docker/github-actionsare handled today. Note Dependabot cannot see versions inside workflowrun:steps, which is why the manifest route is used instead of pinning insidenpx mint@x.y.z.Verification
Full CI flow executed locally against this tree (node 26 / npm 11, lockfile format v3):
mint validatepasses on the current docs content; the only pre-existing local failure mode was a flaky puppeteer chrome download, now skipped in CI viaPUPPETEER_SKIP_DOWNLOAD=1(validate is static).Moved upstream: ENTERPILOT#1081, tracking upstream issue ENTERPILOT#1080.