feat: English ITN enhancements from NeMo reference#361
Merged
Conversation
Time:
- Support numeric minutes with "past" (e.g. "ten past four" -> 04:10)
- Add "till" as alias for "to" (e.g. "quarter till two" -> 01:45)
- Add "o' clock" and "o clock" variants
- Zero-pad hours in to_hour.tsv
Telephone:
- Add "triple X" support (e.g. "triple five" -> 555)
Date:
- Add BCE, CE and long-form year suffixes
- Add H1/H2 financial half-year periods
- Add century ("nineteen hundreds" -> 1900s) and millennium ranges
- Add "X hundred" year form (e.g. "nineteen hundred" -> 1900)
Measure:
- Replace cdrewrite with finite string_map for pluralization (fixes OOM)
- Add -ies/-es rules and irregular plurals (feet, inches, ounces)
- Fix "per" unit priority to prefer direct TSV matches (e.g. mph)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backport features from NeMo's English ITN that were supported in code but not covered by their test suite.
Time
to_hour.tsvTelephone
Date
Measure
cdrewriteonVSIGMAwith finitestring_mapfor pluralization — fixes OOM on runtime composemphovermi/h)Test plan