fix: OpenFst compatibility + add C++ runtime CI (#359)#360
Merged
Conversation
Trigger on runtime/** changes. Builds on ubuntu and macos.
The project uses csukuangfj/openfst v1.8.5 which keeps the original fst::TokenType enum. The previous commit incorrectly renamed it to StringTokenType (which is used in official OpenFst releases).
Both StringCompiler and StringPrinter default to BYTE mode, so the argument can be omitted entirely. This avoids the TokenType vs StringTokenType naming difference between the csukuangfj fork and official OpenFst releases.
pengzhendong
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TokenTypecompilation error by omitting the explicitTokenType::BYTEargument — bothStringCompilerandStringPrinterdefault to BYTE mode, so this works with both the csukuangfj/openfst fork (fst::TokenType) and official OpenFst 1.8+ (fst::StringTokenType)runtime.ymlCI workflow to build C++ runtime onruntime/**changesFixes #359
Test plan