Skip to content

Plan/daily driver - #375

Merged
queil merged 36 commits into
mainfrom
plan/daily-driver
Oct 16, 2026
Merged

queil merged 36 commits into
mainfrom
plan/daily-driver

Conversation

@queil

@queil queil commented Oct 16, 2026

Copy link
Copy Markdown
Contributor

No description provided.

queil added 26 commits October 15, 2026 18:26
…what the REPL refuses; strict init, alias targets refuse chaining
…es nats, weir run gone, the bare surface gated from the env, docs drift fixed
…commands; teach $() for a reifier in let…in
…rminated body; an unsendable header is refused by name at both crossings
…rgv errors, indirect re-enumeration, call-column runtime errors, LSP analysis cache, from xml mixed content
… backlogged classes); per-run e2e process markers
@strix-security

strix-security Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Strix Security Review

Warning

This pull request has 10 commits after the last Strix review (6913665). Strix has not reviewed these changes.
Automatic review on push is off for this repository. To review the latest changes, tag @strix-security in a comment, or turn on re-review on push.

No security issues found.

Review summary

Reviewed all 71 changed files, focusing on the F# runtime source (Http.fs, Serve.fs, Eval.fs, Builtins.fs, Proc.fs, Script.fs, Check.fs, Repl.fs, Session.fs, Parser.fs, Program.fs, Complete.fs, Can.fs, Fmt.fs, Lsp.fs, SchemaTypes.fs). This PR is largely defensive security hardening — it introduces a typed HTTP client (redirect credential-drop, header-injection refusal, URL userinfo redaction) and a loopback-only HTTP server (body bounds, header-injection refusal, stream truncation), adds Secret argv masking, and refactors the init-file load/check into a shared path. Feature additions (Env.need/getOr, Seq.initInfinite, JSON Yaml nodes, anon record types, alias directives, LSP analysis cache) were traced source-to-sink against the project's stated trust model (a .weir script is as trusted as a shell script; untrusted input means malformed/hostile data). Two candidates were assessed and ruled out: jsonYamlNode's recursion is bounded by System.Text.Json.JsonDocument.Parse's default max depth of 64, and the #alias parser restricts names/chain-glyphs and resolves single-hop. No critical, high, medium, or low security findings requiring change were identified in the changed code.

Updated for 6913665.


Reviewed by Strix
Re-run review · Configure security review settings

queil added 3 commits October 16, 2026 09:08
…re-crossable value type; assembly errors located line:col; doc fixes for late imports and let-in commands
@queil
queil force-pushed the plan/daily-driver branch from 6913665 to 8032633 Compare October 16, 2026 09:11
@queil
queil merged commit 80cbdf6 into main Oct 16, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant