Skip to content

Fix/hunt2 language - #372

Merged
queil merged 24 commits into
fix/hunt2-runtimefrom
fix/hunt2-language
Oct 15, 2026
Merged

queil merged 24 commits into
fix/hunt2-runtimefrom
fix/hunt2-language

Conversation

@queil

@queil queil commented Oct 14, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@strix-security

strix-security Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Strix Security Review

Warning

This pull request has 67 commits after the last Strix review (80d8e8d). Strix has not reviewed these changes.
Automatic review on push is off for this repository. To review the latest changes, tag @strix-security in a comment, or turn on re-review on push.

No security issues found.

Review summary

PR #372 is a security-hardening change set driven by the second bug hunt. It deletes the undocumented into builtin (which ran sh -c invisible to effect checks), adds a configurable maxBody request-size bound to serve (default 16 MiB, answering 413 past it), introduces a runtime backstop that refuses command spawning while a module body is evaluated, confines restore so it can never overwrite lock.json or the .weir/ root, validates lockfile entries against malformed-input crashes, enforces strict UTF-8 source decoding instead of silent U+FFFD substitution, translates glob bracket classes instead of injecting raw regex text, and fixes the HTTP/serve surfaces (hop-by-hop header stripping, bodyless-response framing, per-line SSE events, cross-origin redirect credential dropping). I traced every new code path — symlink-resolved module identity, Secret splicing into env/argv, the bounded body read, and the spawn-gate teardown kill — and found no newly introduced injection, authorization, SSRF, IDOR, or other exploitable weakness. No security findings were confirmed.

Updated for 80d8e8d.


Reviewed by Strix
Re-run review · Configure security review settings

@queil
queil changed the base branch from main to fix/hunt2-runtime October 14, 2026 20:51
@queil
queil added this pull request to stack #374 October 14, 2026 20:52
@queil
queil force-pushed the fix/hunt2-language branch 4 times, most recently from 3ae4905 to a83dfb0 Compare October 15, 2026 08:02
queil added 23 commits October 15, 2026 08:47
…nd modules; eager forms refused naming why (H58)
@queil
queil force-pushed the fix/hunt2-language branch from a83dfb0 to 406ade8 Compare October 15, 2026 08:48
@queil
queil merged commit 995113a into main Oct 15, 2026
3 of 6 checks passed
@queil
queil deleted the fix/hunt2-language branch October 15, 2026 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant