Repository navigation
Fix webui_get_count() returning 0 for navigation events - #726
Merged
AlbertShown merged 1 commit intoOct 22, 2026
Merged
Conversation
The WebSocket navigation event stores the URL as argument 0 and the WebKitGTK one stores the URL and navigation type as arguments 0 and 1, but neither set `event_inf->count`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
AlbertShown
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #724
WEBUI_EVENT_NAVIGATIONevents now report their argument count. The WebSocket path setsevent_inf->count = 1(the URL), and the WebKitGTK path setsevent_inf->count = 2(the URL and the navigation type). Before this changewebui_get_count(e)returned 0, althoughwebui_get_string(e)returned the URL. Nothing changes insrc/civetweb/orinclude/webui.h.Verified on Linux x64 with the reproducer from the issue in headless Chromium. Before the change it printed
count = 0, and after itcount = 1with the same URL fromwebui_get_string(e), in 3 of 3 runs each. The WebKitGTK change compiles, but I did not run it.🤖 Generated with Claude Code