fix(cc-task): align consult/transfer tabs and lists with agent desktop (CAI-8354) #733
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| export type ConsultTransferAction = 'Consult' | 'Transfer'; | ||
|
|
||
| export type ConsultTransferInteractionContext = { | ||
| contactDirectionType?: string; | ||
| outdialTransferToQueueEnabled?: boolean; | ||
| mediaType?: string; | ||
| }; | ||
|
|
||
| export const isCollaborationAccessEnabled = (access?: string): boolean => access?.toLowerCase() !== 'none'; | ||
|
|
||
| export const isQueueEnabled = ( | ||
| action: ConsultTransferAction, | ||
| allowConsultToQueue: boolean, | ||
| interaction: ConsultTransferInteractionContext, | ||
| isTelephony: boolean | ||
| ): boolean => { | ||
| if (!isTelephony) { | ||
| return true; | ||
| } | ||
|
|
||
| if (action === 'Consult') { | ||
| return allowConsultToQueue; | ||
| } | ||
|
|
||
| const direction = interaction.contactDirectionType?.toUpperCase(); | ||
| if (direction === 'INBOUND') { | ||
| return true; | ||
| } | ||
| if (direction === 'OUTBOUND') { | ||
| return interaction.outdialTransferToQueueEnabled === true; | ||
| } | ||
|
|
||
| return true; | ||
| }; | ||
|
|
||
| export const isAgentsTabVisible = (accessBuddyTeam?: string): boolean => isCollaborationAccessEnabled(accessBuddyTeam); | ||
|
|
||
| export const isQueuesTabVisible = ( | ||
| action: ConsultTransferAction, | ||
| allowConsultToQueue: boolean, | ||
| accessQueue: string | undefined, | ||
| interaction: ConsultTransferInteractionContext, | ||
| isTelephony: boolean | ||
| ): boolean => | ||
| isCollaborationAccessEnabled(accessQueue) && isQueueEnabled(action, allowConsultToQueue, interaction, isTelephony); | ||
|
|
||
| export const isEntryPointTabVisible = ( | ||
| showEntryPointTab: boolean, | ||
| accessEntryPoint: string | undefined, | ||
| isTelephony: boolean | ||
| ): boolean => showEntryPointTab && isTelephony && isCollaborationAccessEnabled(accessEntryPoint); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -468,6 +468,18 @@ export interface ControlProps { | |
| */ | ||
| allowConsultToQueue: boolean; | ||
|
|
||
| /** Desktop Profile collaboration access for queues */ | ||
| accessQueue?: string; | ||
|
|
||
| /** Desktop Profile collaboration access for entry points */ | ||
| accessEntryPoint?: string; | ||
|
|
||
| /** Desktop Profile collaboration access for buddy teams */ | ||
| accessBuddyTeam?: string; | ||
|
Comment on lines
+471
to
+478
There was a problem hiding this comment.
This adds collaboration-access props and changes Consult/Transfer tab behavior in AGENTS.md reference: AGENTS.md:L68-L68 Useful? React with 👍 / 👎. |
||
|
|
||
| /** Interaction context for Consult/Transfer tab visibility */ | ||
| interactionContext?: ConsultTransferInteractionContext; | ||
|
|
||
| /** | ||
| * Flag to enable or disable conference feature | ||
| */ | ||
|
|
@@ -553,6 +565,10 @@ export type CallControlComponentProps = Pick< | |
| | 'consultTimerLabel' | ||
| | 'consultTimerTimestamp' | ||
| | 'allowConsultToQueue' | ||
| | 'accessQueue' | ||
| | 'accessEntryPoint' | ||
| | 'accessBuddyTeam' | ||
| | 'interactionContext' | ||
| | 'lastTargetType' | ||
| | 'setLastTargetType' | ||
| | 'controls' | ||
|
|
@@ -665,6 +681,15 @@ export interface ConsultTransferDialNumberComponentProps { | |
| logger: ILogger; | ||
| } | ||
|
|
||
| /** | ||
| * Interaction fields used for Consult/Transfer tab visibility (Agent Desktop parity). | ||
| */ | ||
| export type ConsultTransferInteractionContext = { | ||
| contactDirectionType?: string; | ||
| outdialTransferToQueueEnabled?: boolean; | ||
| mediaType?: string; | ||
| }; | ||
|
|
||
| /** | ||
| * Interface representing the properties for ConsultTransferPopover component. | ||
| */ | ||
|
|
@@ -682,6 +707,11 @@ export interface ConsultTransferPopoverComponentProps { | |
| onEntryPointSelect: (entryPointId: string, entryPointName: string, allowParticipantsToInteract: boolean) => void; | ||
| onDialNumberSelect: (dialNumber: string, allowParticipantsToInteract: boolean) => void; | ||
| allowConsultToQueue: boolean; | ||
| accessQueue?: string; | ||
| accessEntryPoint?: string; | ||
| accessBuddyTeam?: string; | ||
| interactionContext?: ConsultTransferInteractionContext; | ||
| isTelephony?: boolean; | ||
| /** Options governing popover visibility/behavior */ | ||
| consultTransferOptions?: ConsultTransferOptions; | ||
| isConferenceInProgress?: boolean; | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When
accessBuddyTeamisNONE, this removes the Agents button but the hook still initializesselectedCategoryto Agents and the list rendering at line 254 is not gated byisAgentsTabVisibleFlag. The popover therefore opens with no visible active tab and can still display/select any preloaded buddy agents despite the profile restriction; initialize the selection to the first permitted category and gate the Agents content as well.Useful? React with 👍 / 👎.