Skip to content

Accept an insignificant comma where an array element would be #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
webdevred wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Accept an insignificant comma where an array element would be #238

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions test/Parsing/JbeamSpec.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ module Parsing.JbeamSpec (

import Data.ByteString.Lazy (ByteString)
import Data.ByteString.Lazy qualified as BS (readFile)
import Data.Either (isRight)
import Data.Vector (fromList)
import Data.Void (Void)
import JbeamEdit.Parsing.Common.Helpers
Expand Down Expand Up @@ -186,6 +187,22 @@ invalidSpec =
where
expLabels = foldMap elabel ["a valid scalar", "object", "array"]

{- | BeamNG treats a comma as insignificant, closer to white space than to
structure, so a stray one between two array elements is a file the game
reads. The grammar allows exactly one comma between elements and has nowhere
to put a second, which stops the parse. Issue #230.

This says only that the input is accepted. What the formatter writes back for
the empty slot, a comma or nothing, is a separate decision and needs its own
spec once it is made.
-}
insignificantCommaSpec :: Spec
insignificantCommaSpec =
describe "an array with a stray comma where an element would be"
. it "is accepted, because the game reads it"
$ parseNodesState' nodeParser "[\"id\", ,\"idRef:\"]"
`shouldSatisfy` isRight

invalidNumberSpec :: Spec
invalidNumberSpec =
describe
Expand Down Expand Up @@ -238,6 +255,7 @@ spec :: Spec
spec = do
mapM_ (applyParserSpec nodeParser) specs
invalidSpec
insignificantCommaSpec
invalidNumberSpec
invalidTopNodeSpec
topNodeSpecs
Expand Down
Loading