Repository navigation
chore: bump version to 0.9.0 - #72
Merged
Merged
Conversation
A minor bump, as defined in WebARKitConfig.cpp ("additions to the API,
or other significant backwards-compatible changes in runtime
functionality"): #71 added VisualDatabase::matches() / image_match_t,
and kpmMatching now reports one result per matched page instead of only
the best one. Updates WEBARKIT_HEADER_VERSION_STRING and _MINOR, and the
two gtest assertions that pin the version string.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
PR Summary by QodoBump WebARKitLib version to 0.9.0
AI Description
High-Level Assessment
Files changed (2)
|
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can reply 'qodo' on any finding to push back, ask questions, or dig deeper |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps WebARKitLib to 0.9.0 ahead of the next release.
WebARKitConfig.cpp:WEBARKIT_HEADER_VERSION_STRING"0.8.0"→"0.9.0",WEBARKIT_HEADER_VERSION_MINOR8→9(MAJOR, TINY and DEV unchanged).tests/webarkit_test.cc: the two assertions that pin the version string (TestConfigValues,CheckWebARKitVersion).Why a minor bump
WebARKitConfig.cppdefines MINOR as "additions to the API, or (occasionally) other significant backwards-compatible changes in runtime functionality". Since 0.8.0,devgained both:VisualDatabase::matches()/image_match_t, andkpmMatchingnow reports one result per matched page instead of only the best one. Consumers that loop overkpmGetResultand keep the lastcamPoseF == 0entry should pick the best one instead (see feat: track several NFT markers at once jsartoolkitNFT#658).Release plan (for after this merges)
dev→masterwith "Create a merge commit" (per CONTRIBUTING.md, never squash a branch sync).0.9.0onmasterand publish the GitHub release.Testing
test.ymlbuilds and runs./webarkit_teston push, covering both updated assertions.Refs webarkit/jsartoolkitNFT#635
🤖 Generated with Claude Code