chore(integration): add WV_TEST_* host/port overrides for test instances#2023
Draft
mpartipilo wants to merge 1 commit intomainfrom
Draft
chore(integration): add WV_TEST_* host/port overrides for test instances#2023mpartipilo wants to merge 1 commit intomainfrom
mpartipilo wants to merge 1 commit intomainfrom
Conversation
![orca-security-eu[bot]](https://avatars.githubusercontent.com/in/276244?s=60&v=4){kind=small}
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Infrastructure as Code |  0  0  0  0 |
View in Orca |
| Passed |
SAST | 0 0 0 0 |
View in Orca |
| Passed |
Secrets | 0 0 0 0 |
View in Orca |
| Passed |
Vulnerabilities | 0 0 0 0 |
View in Orca |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2023 +/- ##
==========================================
- Coverage 87.95% 86.71% -1.24%
==========================================
Files 280 298 +18
Lines 21664 22890 +1226
==========================================
+ Hits 19054 19849 +795
- Misses 2610 3041 +431 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mpartipilo
force-pushed
the
chore/test-endpoint-env-vars
branch
from
6cf94ae to
64c21cf
Compare
mpartipilo
changed the title
Allow integration suite endpoints to be overridden via env vars, falling back to current hardcoded defaults when unset: Primary WV_TEST_HOST / WV_TEST_REST_PORT (8080) / WV_TEST_GRPC_PORT (50051) Auth WV_TEST_AUTH_HOST / WV_TEST_AUTH_REST_PORT (8085) / WV_TEST_AUTH_GRPC_PORT (50056) OIDC WV_TEST_OIDC_HOST / WV_TEST_OIDC_OKTA_CC_PORT (8082) / WV_TEST_OIDC_OKTA_USERS_PORT (8083) The conftest fixture API still takes a (rest_port, grpc_port) tuple unchanged. test_auth.py module-level port constants now read from env and connect_to_local / is_auth_enabled call sites pass the matching host explicitly. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
mpartipilo
force-pushed
the
chore/test-endpoint-env-vars
branch
from
64c21cf to
3b50b5a
Compare
mpartipilo
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allow the integration suite's instance endpoints to be overridden via environment variables, matching a convention being introduced across the Weaviate clients. Override-only semantics — defaults preserve existing behavior.
WV_TEST_HOST/WV_TEST_REST_PORT(8080) /WV_TEST_GRPC_PORT(50051)WV_TEST_AUTH_HOST/WV_TEST_AUTH_REST_PORT(8085) /WV_TEST_AUTH_GRPC_PORT(50056)WV_TEST_OIDC_HOST/WV_TEST_OIDC_OKTA_CC_PORT(8082) /WV_TEST_OIDC_OKTA_USERS_PORT(8083)integration/conftest.pyalready covered the primary instance. This PR extends the same pattern tointegration/test_auth.py: module-level port constants now read from env, andconnect_to_local/is_auth_enabledcall sites pass the matching host explicitly instead of hardcodinglocalhost.Test plan
Generated with Claude Code