Handle X11 attention send failures - #33
Draft
warp-agent-staging[bot] wants to merge 1 commit into
Draft
warp-agent-staging[bot] wants to merge 1 commit into
warp-agent-staging[bot] wants to merge 1 commit into
Conversation
4 tasks
Author
|
This PR was generated with Warp. Comment |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Prevent
request_user_attentionfrom panicking when X11 rejects the WM-hints request because the connection has already closed. A successfully sent request still discards its cookie without waiting for a reply.Warp pins this revision in warpdotdev/warp-for-benchmarks#57.
changelogmodule if knowledge of this change could be valuable to users — omitted for this downstream maintenance fix.Validation:
cargo test --no-default-features --features x11cargo clippy --all-targets --no-default-features --features x11 -- -DwarningsThe dead-connection branch was not manually reproduced because it requires invalidating the X11 transport between window creation and the attention request.