Skip to content

Handle X11 attention send failures - #33

Draft
warp-agent-staging[bot] wants to merge 1 commit into
warpdotdev/v0.30.xfrom
factory/recover-x11-user-attention
Draft

warp-agent-staging[bot] wants to merge 1 commit into
warpdotdev/v0.30.xfrom
factory/recover-x11-user-attention

Conversation

@warp-agent-staging

@warp-agent-staging warp-agent-staging Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Prevent request_user_attention from panicking when X11 rejects the WM-hints request because the connection has already closed. A successfully sent request still discards its cookie without waiting for a reply.

Warp pins this revision in warpdotdev/warp-for-benchmarks#57.

  • Tested on all platforms changed — Linux/X11 tests and clippy passed.
  • Added an entry to the changelog module if knowledge of this change could be valuable to users — omitted for this downstream maintenance fix.
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior — no public API or documented behavior changed.
  • Created or updated an example program if it would help users understand this functionality — no example is needed for connection-loss handling.
  • Updated feature matrix, if new features were added or implemented — no feature changed.

Validation:

  • cargo test --no-default-features --features x11
  • cargo clippy --all-targets --no-default-features --features x11 -- -Dwarnings

The dead-connection branch was not manually reproduced because it requires invalidating the X11 transport between window creation and the attention request.

@warp-agent-staging

Copy link
Copy Markdown
Author

This PR was generated with Warp.

Comment @warp-staging-factory on this PR to send it follow-up work.

View run View conversation

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants