Skip to content

Treat X11 WM hints send failure as recoverable - #32

Draft
warp-agent-staging[bot] wants to merge 1 commit into
warpdotdev/v0.30.xfrom
factory/recover-x11-wm-hints-send-89s1
Draft

warp-agent-staging[bot] wants to merge 1 commit into
warpdotdev/v0.30.xfrom
factory/recover-x11-wm-hints-send-89s1

Conversation

@warp-agent-staging

@warp-agent-staging warp-agent-staging Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

A failed X11 WmHints::set send can indicate that the connection closed while an application requested user attention. Treat that send failure as recoverable instead of panicking; successful sends still discard the void cookie's server-side result.

Warp consumes this revision in warpdotdev/warp-for-benchmarks#56.

Validation

  • cargo test --manifest-path /workspace/winit/Cargo.toml --lib --no-default-features --features x11 — 8 tests passed.
  • cargo clippy --manifest-path /workspace/winit/Cargo.toml --lib --no-default-features --features x11 -- -D warnings — passed.
  • cargo fmt --manifest-path /workspace/winit/Cargo.toml --all -- --check — blocked by existing repository-wide formatting differences because the available stable rustfmt cannot apply this checkout's nightly-only options. The changed hunk passes git diff --check.
  • No dedicated regression test: producing this send-time error requires closing a live X11 connection beneath the window object; the targeted X11 build and tests cover compilation of the changed path.

@warp-agent-staging

Copy link
Copy Markdown
Author

This PR was generated with Warp.

Comment @warp-staging-factory on this PR to send it follow-up work.

View run View conversation

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants