Treat X11 WM hints send failure as recoverable - #32
Draft
warp-agent-staging[bot] wants to merge 1 commit into
Draft
warp-agent-staging[bot] wants to merge 1 commit into
warp-agent-staging[bot] wants to merge 1 commit into
Conversation
Author
|
This PR was generated with Warp. Comment |
4 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


A failed X11
WmHints::setsend can indicate that the connection closed while an application requested user attention. Treat that send failure as recoverable instead of panicking; successful sends still discard the void cookie's server-side result.Warp consumes this revision in warpdotdev/warp-for-benchmarks#56.
Validation
cargo test --manifest-path /workspace/winit/Cargo.toml --lib --no-default-features --features x11— 8 tests passed.cargo clippy --manifest-path /workspace/winit/Cargo.toml --lib --no-default-features --features x11 -- -D warnings— passed.cargo fmt --manifest-path /workspace/winit/Cargo.toml --all -- --check— blocked by existing repository-wide formatting differences because the available stable rustfmt cannot apply this checkout's nightly-only options. The changed hunk passesgit diff --check.