Skip to content

Avoid panicking on X11 attention hint send failure - #31

Draft
warp-agent-staging[bot] wants to merge 1 commit into
warpdotdev/v0.30.xfrom
factory/x11-attention-send
Draft

warp-agent-staging[bot] wants to merge 1 commit into
warpdotdev/v0.30.xfrom
factory/x11-attention-send

Conversation

@warp-agent-staging

@warp-agent-staging warp-agent-staging Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

On Linux/X11, requesting attention after the X server disconnects panics while sending WM_HINTS. Treat the send failure as recoverable; successful sends still ignore the returned cookie as before. Warp adopts this commit in warpdotdev/warp-for-benchmarks#53.

  • Tested on all platforms changed — Linux/X11 with Xvfb.
  • Added an entry to the changelog module if knowledge of this change could be valuable to users — omitted for this fork-only crash fix.
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior — no API change.
  • Created or updated an example program if it would help users understand this functionality — existing API usage is unchanged.
  • Updated feature matrix, if new features were added or implemented — no new feature.

Validation

  • The Xvfb regression test failed with Failed to set WM hints: IoError on the original code and passed after the fix.
  • cargo test --no-default-features --features x11,rwh_06 --lib --test x11_user_attention (8 library tests and the regression test passed).
  • cargo clippy --no-default-features --features x11,rwh_06 --lib --test x11_user_attention -- -D warnings passed.

Plans:

@warp-agent-staging

Copy link
Copy Markdown
Author

This PR was generated with Warp.

Comment @warp-staging-factory on this PR to send it follow-up work.

View run View conversation

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants