Avoid panicking on X11 attention hint send failure - #31
Draft
warp-agent-staging[bot] wants to merge 1 commit into
Draft
warp-agent-staging[bot] wants to merge 1 commit into
warp-agent-staging[bot] wants to merge 1 commit into
Conversation
Author
|
This PR was generated with Warp. Comment |
8 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


On Linux/X11, requesting attention after the X server disconnects panics while sending
WM_HINTS. Treat the send failure as recoverable; successful sends still ignore the returned cookie as before. Warp adopts this commit in warpdotdev/warp-for-benchmarks#53.changelogmodule if knowledge of this change could be valuable to users — omitted for this fork-only crash fix.Validation
Failed to set WM hints: IoErroron the original code and passed after the fix.cargo test --no-default-features --features x11,rwh_06 --lib --test x11_user_attention(8 library tests and the regression test passed).cargo clippy --no-default-features --features x11,rwh_06 --lib --test x11_user_attention -- -D warningspassed.Plans: