Do not panic when sending X11 WM hints fails - #30
Draft
warp-agent-staging[bot] wants to merge 1 commit into
Draft
warp-agent-staging[bot] wants to merge 1 commit into
warp-agent-staging[bot] wants to merge 1 commit into
Conversation
Author
|
This PR was generated with Warp. Comment |
4 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Prevents X11
request_user_attentionfrom panicking whenWmHints::setcannot send because the X connection has died. Successful sends continue to discard the asynchronous cookie without checking it.Warp consumes this revision in warpdotdev/warp-for-benchmarks#52.
cargo test --no-default-features --features=x11changelogmodule if knowledge of this change could be valuable to users — internal error-handling fix onlyValidation
cargo test --no-default-features --features=x11cargo clippy --all-targets --no-default-features --features=x11 -- -Dwarningscargo fmtA focused automated regression test would require a real X server connection that is terminated during the request or a production-only connection seam, so this change relies on the X11 compile/test coverage above.