Clip requested action text in narrow panes#11238
Draft
moirahuang wants to merge 1 commit into
Draft
Conversation
Co-Authored-By: Oz <oz-agent@warp.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Clips requested action row body content to the same shrinkable bounds as the rounded row background. This prevents long action text (for example file paths like
skills-lock.json:6) from painting past the row background when the pane is narrow.Linked Issue
ready-to-specorready-to-implement.Slack feedback: https://warp-core.slack.com/archives/C08KTPNQN65/p1779141317356059
Testing
cargo fmt -p warp --check --manifest-path /workspace/warp/Cargo.tomlcargo check -p warp --manifest-path /workspace/warp/Cargo.tomlcargo clippy -p warp --all-targets --manifest-path /workspace/warp/Cargo.toml -- -D warnings(blocked by unrelated existing clippy errors inwarpui_core/warpui; the first failures areclippy::collapsible_match,clippy::unnecessary_unwrap, andclippy::unnecessary_sort_byoutside this change)./script/run(not run in this headless sandbox)Screenshots / Videos
Original Slack screenshot showed action text overflowing past the rounded row background at narrow pane widths. I was not able to capture a local UI screenshot in this headless sandbox.
Agent Mode
CHANGELOG-BUG-FIX: Fixed AI inline action row text overflowing past its rounded background in narrow panes.
Conversation: https://staging.warp.dev/conversation/d4528770-a5bc-4402-a923-0b994ca20545
Run: https://oz.staging.warp.dev/runs/019e3d16-30b6-76af-a06f-bbc828128c77
This PR was generated with Oz.