-
Notifications
You must be signed in to change notification settings - Fork 21
docs: document WARP_SKILL_DIRS for cloud agent runs #506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+22
−0
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
b221305
docs: document WARP_SKILL_DIRS for cloud agent runs
hongyi-chen 9e8df72
Merge branch 'main' into docs/warp-skill-dirs-cloud-runs
hongyi-chen 96b846f
docs: correct third-party harness support for WARP_SKILL_DIRS
warp-agent-staging[bot] 3bcf192
Merge branch 'main' into docs/warp-skill-dirs-cloud-runs
hongyi-chen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure if this one is necessary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kept this one — checked
skill_manager.rs(add_skills_dirs_skills) and it's real, distinct behavior:WARP_SKILL_DIRSskills register atSkillScope::Homeprecedence, so they're always in scope for the run regardless of the current working directory, unlike repo skills which only apply while the agent is working in that repo. A same-named repo skill isn't shadowed either — both stay addressable, which is exactly the case the linked skill-name-conflicts section covers. Without this bullet a reader has no way to know WARP_SKILL_DIRS skills behave like personal skills rather than repo skills, so I think it earns its place. Let me know if you'd rather see it trimmed further or reworded.