fix: Windows compatibility — skip /dev/tty, guard jq dependency#68
Open
ytzhao wants to merge 1 commit into
Open
fix: Windows compatibility — skip /dev/tty, guard jq dependency#68ytzhao wants to merge 1 commit into
ytzhao wants to merge 1 commit into
Conversation
ytzhao
commented
Jun 16, 2026
ytzhao
commented
- Add _is_windows() helper to detect MSYS/MINGW/Cygwin environments
- Skip /dev/tty writes on Windows (no such device), always use terminalSequence JSON path instead
- Add early-exit guard in build-payload.sh when jq is missing, with a clear error message instead of confusing 'command not found'
- Add tests for _is_windows, Windows emit_terminal_sequence fallback, and jq-missing graceful degradation
- Update README with platform-specific jq install instructions
- Add _is_windows() helper to detect MSYS/MINGW/Cygwin environments - Skip /dev/tty writes on Windows (no such device), always use terminalSequence JSON path instead - Add early-exit guard in build-payload.sh when jq is missing, with a clear error message instead of confusing 'command not found' - Add tests for _is_windows, Windows emit_terminal_sequence fallback, and jq-missing graceful degradation - Update README with platform-specific jq install instructions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.