Skip to content

ci: verify clean-branch unit test fixes - #18

Closed
warku123 wants to merge 12 commits into
release_v4.8.3from
verify/retry-zero-clean
Closed

warku123 wants to merge 12 commits into
release_v4.8.3from
verify/retry-zero-clean

Conversation

@warku123

@warku123 warku123 commented Sep 16, 2026

Copy link
Copy Markdown
Owner

Validation-only draft PR (do not merge). Triggers 3-round retry=0 full-chain verification for the clean-branch test fixes (no 3for content). Base: release_v4.8.3.


Summary by cubic

Validation-only draft PR (do not merge) that verifies the clean-branch test isolation fixes on release_v4.8.3 by running three rounds of the suite with Gradle test retries disabled. Retries could previously rerun failed tests and hide static state pollution; this run forces maxRetries=0 and fails on any nonzero Gradle exit, on Linux JDK 8 and macOS JDK 17.

Test Isolation

  • PeerManagerStateResetter drains the executor, disconnects residual peers, zeroes counters, and runs in BaseTest/BaseMethodTest and five p2p/handler test classes.
  • VMConfigRule snapshots and restores VM flags via rules on BaseTest and BaseMethodTest.
  • SendCoinShieldTest and ShieldedReceiveTest restore allowShieldedTransaction per test; ShieldedReceiveTest initializes the witness schedule once without racing the background producer, and TransactionsMsgHandlerTest waits on a latch, shuts down swapped-out pools, and uses mock pools that never execute the async worker so Mockito stubbing races are avoided.
  • AllowTvmLondonTest fixes the base-fee assertion order, backup tests replace sleeps with condition waits and tear down channels/executors, and fixed ports (5555, Prometheus) are randomized.
  • Native message queues are released via stopPlugin() in finally/teardown paths so sockets are freed even on assertion failures.

CI Verification

  • Workflow runs clean build, testWithRocksDb, and jacocoTestReport in three rounds with retries forced to 0 via retry_zero.init.gradle, on both Linux JDK 8 and macOS JDK 17.
  • jacoco_baseline_summary.py emits per-round JaCoCo/JUnit summaries and evidence manifests.

Written for commit f37a38b. Summary will update on new commits.

Review in cubic

@coderabbitai

coderabbitai Bot commented Sep 16, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@warku123

Copy link
Copy Markdown
Owner Author

Closing: superseded by PR #19 (fix/unit-test-cleanup-release, release_v4.8.3 base). This verification branch served its retry=0 evidence purpose; branch will be removed.

@warku123 warku123 closed this Sep 16, 2026
@warku123
warku123 deleted the verify/retry-zero-clean branch September 16, 2026 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant