Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Owner
Author
|
Closing: superseded by PR #19 (fix/unit-test-cleanup-release, release_v4.8.3 base). This verification branch served its retry=0 evidence purpose; branch will be removed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validation-only draft PR (do not merge). Triggers 3-round retry=0 full-chain verification for the clean-branch test fixes (no 3for content). Base: release_v4.8.3.
Summary by cubic
Validation-only draft PR (do not merge) that verifies the clean-branch test isolation fixes on
release_v4.8.3by running three rounds of the suite with Gradle test retries disabled. Retries could previously rerun failed tests and hide static state pollution; this run forcesmaxRetries=0and fails on any nonzero Gradle exit, on Linux JDK 8 and macOS JDK 17.Test Isolation
PeerManagerStateResetterdrains the executor, disconnects residual peers, zeroes counters, and runs inBaseTest/BaseMethodTestand five p2p/handler test classes.VMConfigRulesnapshots and restores VM flags via rules onBaseTestandBaseMethodTest.SendCoinShieldTestandShieldedReceiveTestrestoreallowShieldedTransactionper test;ShieldedReceiveTestinitializes the witness schedule once without racing the background producer, andTransactionsMsgHandlerTestwaits on a latch, shuts down swapped-out pools, and uses mock pools that never execute the async worker so Mockito stubbing races are avoided.AllowTvmLondonTestfixes the base-fee assertion order, backup tests replace sleeps with condition waits and tear down channels/executors, and fixed ports (5555, Prometheus) are randomized.stopPlugin()in finally/teardown paths so sockets are freed even on assertion failures.CI Verification
clean build,testWithRocksDb, andjacocoTestReportin three rounds with retries forced to 0 viaretry_zero.init.gradle, on both Linux JDK 8 and macOS JDK 17.jacoco_baseline_summary.pyemits per-round JaCoCo/JUnit summaries and evidence manifests.Written for commit f37a38b. Summary will update on new commits.