Simplify workflow - #641
Draft
ngrayluna wants to merge 5 commits into
Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR simplifies the .agents/ skill surface by removing vendored marimo skills, consolidating repo-specific marimo notebook guidance into a single skill with focused reference docs, and moving deterministic conversion/check steps into a shell script plus .gitignore support for temporary conversion artifacts.
Changes:
- Replaces multiple marimo-related skills with a single
marimo-wandb-notebooksskill + targeted reference docs. - Adds
prepare-marimo-example.shto script marimo conversion +marimo checkoutput capture. - Removes vendored skill content (and Apache-2.0 license files) and updates
.gitignoreto ignore.conversion/outputs.
Reviewed changes
Copilot reviewed 26 out of 27 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| .gitignore | Ignores marimo conversion debug output directories under examples. |
| .agents/skills/README.md | Updates skill index to point to the consolidated marimo skill and the new script. |
| .agents/skills/marimo-wandb-notebooks/SKILL.md | New consolidated skill documenting repo conventions and review checklist for marimo examples. |
| .agents/skills/marimo-wandb-notebooks/references/wandb-patterns.md | Adds W&B-specific notebook integration patterns (auth, reruns, expected failures). |
| .agents/skills/marimo-wandb-notebooks/references/marimo-idioms.md | Adds marimo idioms and a compact checklist for reactivity, gating, and rendering. |
| .agents/skills/marimo-wandb-notebooks/references/conversion-cleanup.md | Adds post-conversion cleanup checklist for polishing converted notebooks. |
| .agents/skills/marimo-notebook/SKILL.md | Removes vendored marimo notebook guidance skill. |
| .agents/skills/marimo-notebook/references/WATCHING.md | Removes vendored reference doc. |
| .agents/skills/marimo-notebook/references/UI.md | Removes vendored reference doc. |
| .agents/skills/marimo-notebook/references/TOP-LEVEL-IMPORTS.md | Removes vendored reference doc. |
| .agents/skills/marimo-notebook/references/STATE.md | Removes vendored reference doc. |
| .agents/skills/marimo-notebook/references/SQL.md | Removes vendored reference doc. |
| .agents/skills/marimo-notebook/references/REACTIVITY.md | Removes vendored reference doc. |
| .agents/skills/marimo-notebook/references/PYTEST.md | Removes vendored reference doc. |
| .agents/skills/marimo-notebook/references/EXPORTS.md | Removes vendored reference doc. |
| .agents/skills/marimo-notebook/references/EXPENSIVE.md | Removes vendored reference doc. |
| .agents/skills/marimo-notebook/references/DEPLOYMENT.md | Removes vendored reference doc. |
| .agents/skills/marimo-notebook/references/CONFIGURATION.md | Removes vendored reference doc. |
| .agents/skills/marimo-notebook/references/COLUMNS.md | Removes vendored reference doc. |
| .agents/skills/marimo-notebook/references/ANYWIDGET.md | Removes vendored reference doc. |
| .agents/skills/marimo-notebook/LICENSE | Removes vendored Apache-2.0 license file associated with removed vendored skill. |
| .agents/skills/marimo-example-notebook/SKILL.md | Removes the prior repo-specific marimo example skill in favor of the new consolidated skill. |
| .agents/skills/jupyter-to-marimo/SKILL.md | Removes vendored Jupyter→marimo conversion skill in favor of scripted conversion. |
| .agents/skills/jupyter-to-marimo/references/widgets.md | Removes vendored reference doc. |
| .agents/skills/jupyter-to-marimo/references/latex.md | Removes vendored reference doc. |
| .agents/skills/jupyter-to-marimo/LICENSE | Removes vendored Apache-2.0 license file associated with removed vendored skill. |
| .agents/scripts/prepare-marimo-example.sh | Adds deterministic conversion/check/report generation script for .ipynb → marimo .py. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+72
to
+74
| module_name="${slug//-/_}" | ||
| target_dir="examples/marimo/$slug" | ||
| target_py="$target_dir/$module_name.py" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplifies
.agent/directory:prepare-marimo-example.sh) script that:*.ipynbnotebook to*.pyusingmarimo convertmarimo check.pyfile the agent should look atFor the last point, the logic is that we don't need an agent to call a deterministic step since we can easily do this (and for free) with a shell script. Instead, reserve resources for agent to do things that are not easily scriptable.